-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/fixup release with upstream #262
Merged
0xFable
merged 57 commits into
release/v2_contracts
from
chore/fixup-release-with-upstream
Feb 8, 2024
Merged
Chore/fixup release with upstream #262
0xFable
merged 57 commits into
release/v2_contracts
from
chore/fixup-release-with-upstream
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decimals check to allow other accounts via authz call this message without sending funds
ci: fix release artifacts ci action
… pair or trio with token factory tokens
kerber0x
reviewed
Feb 8, 2024
$GITHUB_WORKSPACE/scripts/build_release.sh | ||
tar -zcvf cosmwasm-artifacts.tar.gz artifacts | ||
$GITHUB_WORKSPACE/scripts/build_release.sh -c vanilla | ||
tar -zcvf cosmwasm-artifacts_no-token-factory.tar.gz artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i thought i had renamed this to "vanilla" but seems like not :D
kerber0x
reviewed
Feb 8, 2024
@@ -5,4 +5,4 @@ use white_whale_std::epoch_manager::epoch_manager::{Config, EpochV2}; | |||
pub const CONFIG: Item<Config> = Item::new("config"); | |||
pub const ADMIN: Admin = Admin::new("admin"); | |||
pub const HOOKS: Hooks = Hooks::new("hooks"); | |||
pub const EPOCHS: Map<&[u8], Epoch> = Map::new("epochs"); | |||
pub const EPOCHS: Map<&[u8], EpochV2> = Map::new("epochs"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This EpochV2 thing we need to address soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Merged up what I could via the normal merge viewer with a preference for incoming changes (new master stuff)
Then manually went through and tried to fixup the areas which had an unrecoverable diff.
Checked most contracts and tests are passing.
Have review most of the incoming stuff has come in and most of the work on v2 branch is still there the main area I have concern about is tokenfactory.rs in white-whale-std package
Related Issues
Checklist:
Update index.md
)cargo fmt --all --
.cargo clippy -- -D warnings
.cargo schema
.