Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fixup release with upstream #262

Merged
merged 57 commits into from
Feb 8, 2024

Conversation

0xFable
Copy link
Contributor

@0xFable 0xFable commented Jan 31, 2024

Description and Motivation

Merged up what I could via the normal merge viewer with a preference for incoming changes (new master stuff)
Then manually went through and tried to fixup the areas which had an unrecoverable diff.
Checked most contracts and tests are passing.
Have review most of the incoming stuff has come in and most of the work on v2 branch is still there the main area I have concern about is tokenfactory.rs in white-whale-std package

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

kerber0x and others added 30 commits December 11, 2023 15:48
…decimals check to allow other accounts via authz call this message without sending funds
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 471 lines in your changes are missing coverage. Please review.

Comparison is base (dea7605) 94.68% compared to head (a6119a2) 93.20%.
Report is 64 commits behind head on release/v2_contracts.

Files Patch % Lines
...quidity_hub/pool-manager/src/tests/mock_querier.rs 0.00% 118 Missing ⚠️
...ontracts/liquidity_hub/pool-manager/src/helpers.rs 60.19% 80 Missing ⚠️
...acts/liquidity_hub/pool-manager/src/tests/suite.rs 77.67% 50 Missing ⚠️
...ntracts/liquidity_hub/pool-manager/src/contract.rs 66.39% 41 Missing ⚠️
...uidity_hub/pool-manager/src/tests/temp_mock_api.rs 0.00% 34 Missing ⚠️
...quidity_hub/pool-manager/src/liquidity/commands.rs 73.21% 30 Missing ⚠️
...ontracts/liquidity_hub/pool-manager/src/queries.rs 70.83% 28 Missing ⚠️
contracts/liquidity_hub/pool-manager/src/state.rs 31.42% 24 Missing ⚠️
...liquidity_hub/pool-manager/src/manager/commands.rs 82.45% 20 Missing ⚠️
...ity_hub/pool-network/terraswap_pair/src/helpers.rs 73.68% 10 Missing ⚠️
... and 11 more
Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #262      +/-   ##
========================================================
- Coverage                 94.68%   93.20%   -1.49%     
========================================================
  Files                       240      258      +18     
  Lines                     26854    28713    +1859     
========================================================
+ Hits                      25427    26761    +1334     
- Misses                     1427     1952     +525     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

$GITHUB_WORKSPACE/scripts/build_release.sh
tar -zcvf cosmwasm-artifacts.tar.gz artifacts
$GITHUB_WORKSPACE/scripts/build_release.sh -c vanilla
tar -zcvf cosmwasm-artifacts_no-token-factory.tar.gz artifacts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i thought i had renamed this to "vanilla" but seems like not :D

@@ -5,4 +5,4 @@ use white_whale_std::epoch_manager::epoch_manager::{Config, EpochV2};
pub const CONFIG: Item<Config> = Item::new("config");
pub const ADMIN: Admin = Admin::new("admin");
pub const HOOKS: Hooks = Hooks::new("hooks");
pub const EPOCHS: Map<&[u8], Epoch> = Map::new("epochs");
pub const EPOCHS: Map<&[u8], EpochV2> = Map::new("epochs");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This EpochV2 thing we need to address soon.

@0xFable 0xFable merged commit a3fab85 into release/v2_contracts Feb 8, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants