ci: improve pre-commit hook #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerber0x
requested review from
0xFable,
kaimen-sano and
Sen-Com
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 218 218
Lines 24691 24691
=======================================
Hits 23314 23314
Misses 1377 1377 ☔ View full report in Codecov by Sentry. |
kerber0x
commented
Feb 1, 2024
| @@ -18,6 +18,9 @@ test FEATURE='': | |||
| cargo test --features {{FEATURE}} | |||
| fi | |||
|
|
|||
| fmt: | |||
| @just format | |||
There was a problem hiding this comment.
Added an alias for just format, so you can also do just fmt
kerber0x
commented
Feb 1, 2024
| COMMIT_MSG=$(cat "$COMMIT_MSG_FILE") | ||
|
|
||
| # Regular expression to match Conventional Commits format | ||
| CONVENTIONAL_COMMIT_REGEX="^(feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)(\(\S+\))?: .+$" |
There was a problem hiding this comment.
tried to do it with convco first but it was giving me some issues so i just did a regex :P
0xFable
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
This PR improves the pre-commit hook, formatting not only rust files but also toml and shell scripts files.
It also introduces a commit-msg hook, which makes sure the conventional commit format is being used.
Related Issues
Checklist:
Update index.md)cargo fmt --all --.cargo clippy -- -D warnings.cargo schema.