Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fix osmosis fee payment #269

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Feat/fix osmosis fee payment #269

merged 4 commits into from
Feb 6, 2024

Conversation

kerber0x
Copy link
Contributor

@kerber0x kerber0x commented Feb 5, 2024

Description and Motivation

This PR adds the osmosis pool interface to the pair contract so that it pays the the osmosis taker fee (to the community pool) in case the swap isn't executed via the osmosis frontend, which already takes the fee.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (418bf25) 94.42% compared to head (2af4791) 94.41%.

Files Patch % Lines
...-network/frontend_helper/src/reply/deposit_pair.rs 0.00% 4 Missing ⚠️
...ault-network/vault_router/src/execute/next_loan.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   94.42%   94.41%   -0.01%     
==========================================
  Files         218      218              
  Lines       24691    24687       -4     
==========================================
- Hits        23314    23309       -5     
- Misses       1377     1378       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kerber0x kerber0x merged commit c803cc5 into main Feb 6, 2024
5 of 6 checks passed
@kerber0x kerber0x deleted the feat/fix-osmosis-fee-payment branch February 6, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants