Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore possible errors when closing positions due to rewards ca… #272

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

kerber0x
Copy link
Contributor

@kerber0x kerber0x commented Feb 6, 2024

…lculations

Description and Motivation

This PR allows users closing positions on incentives even if an error occurs when calculating rewards as they are closing the position anyway.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link
Contributor

@nseguias nseguias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kerber0x kerber0x merged commit 4f82a12 into feat/lunc Feb 6, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants