fix: Add input append_body and generate_release_notes, set both to true #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFable
requested review from
kerber0x,
kaimen-sano and
Sen-Com
as code owners
This should: Allow us to pass the artifact versions.txt and have it appended to the generated release notes https://github.com/softprops/action-gh-release/blob/4634c16e79c963813287e889244c50009e7f0981/src/github.ts#L244
0xFable
force-pushed
the
fix/release-text
branch
from
9976726 to
ced0ad6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 219 219
Lines 24858 24858
=======================================
Hits 23482 23482
Misses 1376 1376 ☔ View full report in Codecov by Sentry. |
kaimen-sano
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
LGTM, I'm unsure if we need both append_body and generate_release_notes, but can't hurt to have both.
The generate_release_notes docs state:
If body is specified, the body will be pre-pended to the automatically generated notes. See the GitHub docs for this feature for more information
kerber0x
added a commit
that referenced
this pull request
Mar 1, 2024
* ci: add script to get contract versions * ci: fix script for vault deployment * ci: add script to extract pool information * ci: add comments to extract_pools script to make it clear * chore: since the pool factory is permissioned, remove the add_native_decimals check to allow other accounts via authz call this message without sending funds * chore: bump pool factory version * test: remove irrelevant add_native_decimals test * ci: add artifact versions to github releases * ci: fix release artifacts ci action * ci: add chihuahua deployment to ci release script * ci: remove the token factory release builds since the docker images don't exists * ci: add osmosis chain to release script * docs(contributing): add protobuf step, reference PyO3 * chore: add osmosis flag * chore: factory osmosis flag * chore: impl pair osmosis flag changes * chore: impl 3pool osmosis flag * chore: making clippy happy * test: fixing tests for the osmosis flag * chore: send osmosis fee to community pool * chore: remove the uneccesary osmosis fee addr from factory and pools * chore: make clippy happy * ci: make release script add osmosis flag if needed * ci: add vanilla variant to build release script for ci (#244) * chore: fix pool factory migration to 1.2.0 condition (#250) * ci: tweak env variables * ci: script to extract vault info * chore: prepare white-whale package for being published * chore: print the white-whale package version when building release * chore: renaming white-whale package to white-whale-std * ci: add a few more commands to the justfile * ci: fix and format bash scripts * ci: fix doc link on white-whale-std * chore: forces the protobuff version to be 3.2.0 * chore: forward fees from first epoch to the upcoming one * chore: this removes the sanity check preventing to add burn fees to a pair or trio with token factory tokens * ci: Specify body_path with artifact_Versions.txt on release to print the new contract versions * ci: improve pre-commit hook * feat: load chain env variables on demand * feat(smart-contracts): add remove swap routes in pool router & clean-up clippy warnings * feat(smart-contracts): add remove swap routes in pool router & clean-up clippy warnings * chore(smart-contracts): regenerate all schemas * feat(smart-contracts): add verbose error when trying to remove a swap route that does not exist * chore: adds the osmosis pool ininterface to the pool config and verify where the swap is being executed * test: add tests for the new cosmwasm_i_pool_interface value * chore: bump pool contract version * chore: fix clippy warnings * ci: adds a script to install a local alias to load env variables on demand * ci: consolidate base.env files into base_env.sh * docs: improve message after script installation * fix(smart-contracts): ignore possible errors when closing position on incentives * chore(scripts): reverted commit as it was addressed in another PR * ci: adds just recipes for deploying and store contracts * ci: add recipe to migrate contracts * chore(smart-contracts): disable-entrypoint-for-remove-swap-routes-in-pool-router * chore(smart-contracts): make remove_swap_routes function private * chore: add recipe for renaming aarch64 wasm files to make it compatible with other scripts * fix(scripts): rename CHAIN-ID on sei.env * fix: bump pool factory version to include the newly added cosmwasm_interface_contract param when updating pair configs on osmosis * chore: publish a new version of the white-whale-std package including osme osmosis changes * docs: Document usage of `just` command line runner (#283) In #274 we introduced an env loader for the CLI to simplify and unify our commands used in the repository. This commit documents the usage of the `just` command runner for new users of the repository. * ci: add narwhal-2 env variables * fix: broken vault state migration (#284) * fix: Add input append_body and generate_release_notes, set both to true (#286) This should: Allow us to pass the artifact versions.txt and have it appended to the generated release notes https://github.com/softprops/action-gh-release/blob/4634c16e79c963813287e889244c50009e7f0981/src/github.ts#L244 * fix: clippy warning * fix: use safe math --------- Co-authored-by: kaimen-sano <[email protected]> Co-authored-by: 0xFable <[email protected]> Co-authored-by: nahem <[email protected]> Co-authored-by: 0xFable <[email protected]> Co-authored-by: nahem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should:
Allow us to pass the artifact versions.txt and have it appended to the generated release notes https://github.com/softprops/action-gh-release/blob/4634c16e79c963813287e889244c50009e7f0981/src/github.ts#L244
Description and Motivation
Related Issues
Checklist:
Update index.md)cargo fmt --all --.cargo clippy -- -D warnings.cargo schema.