Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to V2 branch #287

Merged
merged 103 commits into from
Mar 1, 2024
Merged

Merge main to V2 branch #287

merged 103 commits into from
Mar 1, 2024

Conversation

kerber0x
Copy link
Contributor

Description and Motivation

This PR merges the changes done in the main branch, mostly related to the osmosis pool interface.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

kerber0x and others added 30 commits December 11, 2023 15:48
…decimals check to allow other accounts via authz call this message without sending funds
nseguias and others added 20 commits February 7, 2024 23:15
…sible-errors-on-close-position

fix(smart-contracts): ignore possible errors when closing position on…
…entrypoint-for-remove-swap-routes-in-pool-router

chore(smart-contracts): disable-entrypoint-for-remove-swap-routes-in-…
…-chain-id-on-env-file

fix(scripts): rename CHAIN-ID on sei.env
…terface_contract param when updating pair configs on osmosis
In #274 we introduced an env loader for the CLI to simplify and unify
our commands used in the repository. This commit documents the usage of
the `just` command runner for new users of the repository.
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 96.75676% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 93.28%. Comparing base (dea7605) to head (683dab2).
Report is 65 commits behind head on release/v2_contracts.

Files Patch % Lines
...ontracts/liquidity_hub/pool-manager/src/helpers.rs 76.74% 10 Missing ⚠️
...quidity_hub/pool-manager/src/liquidity/commands.rs 75.00% 1 Missing ⚠️
...y_hub/pool-network/terraswap_router/src/helpers.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #287      +/-   ##
========================================================
- Coverage                 94.68%   93.28%   -1.41%     
========================================================
  Files                       240      258      +18     
  Lines                     26854    28846    +1992     
========================================================
+ Hits                      25427    26909    +1482     
- Misses                     1427     1937     +510     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x changed the title Chore/merge main Merge main to V2 branch Feb 29, 2024
Copy link
Contributor

@nseguias nseguias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments about safe math but it looks good overall. Also check that tests pass as I saw them fail

@kerber0x kerber0x merged commit 4a7a545 into release/v2_contracts Mar 1, 2024
3 of 6 checks passed
@kerber0x kerber0x deleted the chore/merge_main branch March 1, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants