Allow updating config of pool-manager #328
Conversation
kaimen-sano
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v2_contracts #328 +/- ##
=====================================================
Coverage 89.42% 89.42%
=====================================================
Files 260 261 +1
Lines 26656 26704 +48
=====================================================
+ Hits 23836 23879 +43
- Misses 2820 2825 +5 ☔ View full report in Codecov by Sentry. |
kerber0x
force-pushed
the
pool-manager-update-config
branch
from
f8761f6 to
f5d12b9
Compare
| withdrawals_enabled: false, | ||
| }), | ||
| |res| { | ||
| res.unwrap(); |
There was a problem hiding this comment.
LGTM good job keeping the tests in ownership test module
| use crate::{ | ||
| helpers::{self, calculate_stableswap_y, StableSwapDirection}, | ||
| state::get_pair_by_identifier, | ||
| ContractError, | ||
| }; | ||
| use crate::{math::Decimal256Helper, state::SWAP_ROUTES}; | ||
|
|
||
| /// Query the config of the contract. | ||
| pub fn query_config(deps: Deps) -> Result<Config, ContractError> { | ||
| Ok(MANAGER_CONFIG.load(deps.storage)?) |
There was a problem hiding this comment.
given that we have several managers on V2, can we use POOL_MANAGER_CONFIG to make it super clear? Or just CONFIG
There was a problem hiding this comment.
yeah maybe just config could be. I remember at first we started naming them MANAGER_CONFIG cuz maybe we could have a config for the pools, or vaults... but that wasn't the case. I think we can refactor that later once all the contracts are ready.
kerber0x
force-pushed
the
pool-manager-update-config
branch
from
c63be19 to
1412749
Compare
Description and Motivation
UpdateConfigmsg to be sent to thepool-managercontract to update the contract configuration.QueryMsg::Configon thepool-managercontractRelated Issues
closes #294, related to #309.
Before merging this PR, we need to have a think about how we want to handle contract ownership. We currently have the cosmwasm contract admin, the
cw-ownableowner, and theConfig.owner.Checklist:
Update index.md)cargo fmt --all --.cargo clippy -- -D warnings.cargo schema.