feat: single-side liquidity provision #345

kerber0x · 2024-04-26T16:54:57Z

Description and Motivation

Enables single-side liquidity provision. Closes #310

Related Issues

Checklist:

I have read Migaloo's contribution guidelines.
My pull request has a sound title and description (not something vague like Update index.md)
All existing and new tests are passing.
I updated/added relevant documentation.
The code is formatted properly cargo fmt --all --.
Clippy doesn't report any issues cargo clippy -- -D warnings.
I have regenerated the schemas if needed cargo schema.

codecov · 2024-04-26T17:01:50Z

Codecov Report

Attention: Patch coverage is 96.77996% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 90.08%. Comparing base (deebeee) to head (5f5b6a8).
Report is 4 commits behind head on release/v2_contracts.

Files	Patch %	Lines
...quidity_hub/pool-manager/src/liquidity/commands.rs	93.44%	8 Missing ⚠️
...ty_hub/pool-manager/src/tests/integration_tests.rs	98.92%	4 Missing ⚠️
...ontracts/liquidity_hub/pool-manager/src/helpers.rs	76.92%	3 Missing ⚠️
...ts/liquidity_hub/pool-manager/src/swap/commands.rs	77.77%	2 Missing ⚠️
...ntracts/liquidity_hub/pool-manager/src/contract.rs	95.83%	1 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##           release/v2_contracts     #345      +/-   ##
========================================================
+ Coverage                 89.86%   90.08%   +0.21%     
========================================================
  Files                       261      261              
  Lines                     27339    27784     +445     
========================================================
+ Hits                      24569    25029     +460     
+ Misses                     2770     2755      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xFable

LGTM, nice small change

0xFable · 2024-04-29T17:27:28Z

I like this implementation but on second view it looks like Osmosis does do a swap before provision rather than only providing to one side.
Additionally looks like Wynd did that too.
The behaviour of single provision and only providing to one side is similar to Uniswap. Do we want maybe to add an option to do the swap?
https://medium.com/osmosis-community-updates/single-asset-lp-67fb48abce53

nseguias

Looks good. Would be nice to make sure that we get the same amount of LP tokens when providing single sided liquidity VS swapping 50% of the assets in the pool and then providing liquidity in the correct ratio

contracts/liquidity_hub/pool-manager/src/error.rs

contracts/liquidity_hub/pool-manager/src/liquidity/commands.rs

nseguias · 2024-04-29T17:00:49Z

contracts/liquidity_hub/pool-manager/src/liquidity/commands.rs

@@ -98,19 +120,19 @@ pub fn provide_liquidity(

                share
            } else {


if there's no else case can we remove it?

There's an else case

contracts/liquidity_hub/pool-manager/src/liquidity/commands.rs

contracts/liquidity_hub/pool-manager/src/tests/integration_tests.rs

kerber0x · 2024-04-30T08:51:31Z

I like this implementation but on second view it looks like Osmosis does do a swap before provision rather than only providing to one side. Additionally looks like Wynd did that too. The behaviour of single provision and only providing to one side is similar to Uniswap. Do we want maybe to add an option to do the swap? https://medium.com/osmosis-community-updates/single-asset-lp-67fb48abce53

Good point. Let's explore doing it this way.

github-actions · 2024-05-01T09:40:36Z

Schema generation had missing jobs:

contracts/liquidity_hub/pool-manager/schema/pool-manager.json
contracts/liquidity_hub/pool-manager/schema/raw/execute.json

Please run just schemas locally and upload the generated schemas.

github-actions · 2024-05-01T09:45:26Z

Schema generation had missing jobs:

contracts/liquidity_hub/pool-manager/schema/pool-manager.json
contracts/liquidity_hub/pool-manager/schema/raw/execute.json

Please run just schemas locally and upload the generated schemas.

0xFable

LGTM nice job adding good coverage over it and finding the issue with fees ⭐

0xFable · 2024-05-01T22:27:00Z

contracts/liquidity_hub/pool-manager/src/swap/perform_swap.rs

@@ -99,36 +103,60 @@ pub fn perform_swap(
    if offer_asset.denom == pools[0].denom {
        pair_info.assets[0].amount += offer_amount;
        pair_info.assets[1].amount -= swap_computation.return_amount;
+        pair_info.assets[1].amount -= swap_computation.protocol_fee_amount;


Great spot on this

nseguias

Nicely done, made a few general comments but it's looking good ser

contracts/liquidity_hub/pool-manager/src/contract.rs

contracts/liquidity_hub/pool-manager/src/helpers.rs

contracts/liquidity_hub/pool-manager/src/liquidity/commands.rs

nseguias · 2024-05-01T11:07:01Z

contracts/liquidity_hub/pool-manager/src/liquidity/commands.rs

+        ContractError::AssetMismatch {}
+    );
+
+    let receiver = receiver.unwrap_or_else(|| info.sender.to_string());


we want to validate the address is correct here

contracts/liquidity_hub/pool-manager/src/manager/commands.rs

contracts/liquidity_hub/pool-manager/src/state.rs

contracts/liquidity_hub/pool-manager/src/swap/commands.rs

contracts/liquidity_hub/pool-manager/src/swap/perform_swap.rs

packages/white-whale-std/src/pool_manager.rs

kerber0x requested review from 0xFable, kaimen-sano and Sen-Com as code owners April 26, 2024 16:54

0xFable approved these changes Apr 29, 2024

View reviewed changes

nseguias approved these changes Apr 29, 2024

View reviewed changes

kerber0x added the Do not merge To be added to PRs that are waiting for something else to be completed label Apr 30, 2024

kerber0x force-pushed the feat/allow-single-asset-liquidity-provision branch from c87ebaa to 5b550a5 Compare May 1, 2024 09:39

kerber0x requested review from nseguias and 0xFable May 1, 2024 09:45

kerber0x removed the Do not merge To be added to PRs that are waiting for something else to be completed label May 1, 2024

kerber0x added 5 commits May 1, 2024 11:19

feat: single-side liquidity provision

eddae9b

chore: make swap before providing liqudity with a single asset

f982008

refactor: tweak code

932aee4

chore: regenerate schemas

26d63dd

test: fix max spread assetion in single-side lp test

a694b5d

kerber0x force-pushed the feat/allow-single-asset-liquidity-provision branch from cfaf507 to a694b5d Compare May 1, 2024 10:33

kerber0x added 2 commits May 1, 2024 13:32

chore: add sanity check when providing liquidity with a single asset

533674d

refactor: tweak code around single asset lp

5f5b6a8

0xFable approved these changes May 1, 2024

View reviewed changes

nseguias approved these changes May 2, 2024

View reviewed changes

kerber0x merged commit d196218 into release/v2_contracts May 2, 2024
7 checks passed

kerber0x deleted the feat/allow-single-asset-liquidity-provision branch May 2, 2024 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: single-side liquidity provision #345

feat: single-side liquidity provision #345

kerber0x commented Apr 26, 2024

codecov bot commented Apr 26, 2024 •

edited

Loading

0xFable left a comment

0xFable commented Apr 29, 2024

nseguias left a comment

nseguias Apr 29, 2024

kerber0x May 1, 2024

kerber0x commented Apr 30, 2024

github-actions bot commented May 1, 2024

github-actions bot commented May 1, 2024

0xFable left a comment

0xFable May 1, 2024

nseguias left a comment

nseguias May 1, 2024

kerber0x May 2, 2024

feat: single-side liquidity provision #345

feat: single-side liquidity provision #345

Conversation

kerber0x commented Apr 26, 2024

Description and Motivation

Related Issues

Checklist:

codecov bot commented Apr 26, 2024 • edited Loading

Codecov Report

0xFable left a comment

Choose a reason for hiding this comment

0xFable commented Apr 29, 2024

nseguias left a comment

Choose a reason for hiding this comment

nseguias Apr 29, 2024

Choose a reason for hiding this comment

kerber0x May 1, 2024

Choose a reason for hiding this comment

kerber0x commented Apr 30, 2024

github-actions bot commented May 1, 2024

github-actions bot commented May 1, 2024

0xFable left a comment

Choose a reason for hiding this comment

0xFable May 1, 2024

Choose a reason for hiding this comment

nseguias left a comment

Choose a reason for hiding this comment

nseguias May 1, 2024

Choose a reason for hiding this comment

kerber0x May 2, 2024

Choose a reason for hiding this comment

codecov bot commented Apr 26, 2024 •

edited

Loading