Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add total LP share amount to the Pair query response #347

Merged
merged 2 commits into from
May 1, 2024

Conversation

kerber0x
Copy link
Contributor

Description and Motivation

Adds the total LP share amount to the Pair query response, as this was a missing piece of information lost when we removed the Pool query.

Related Issues

Closes #344


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.89%. Comparing base (deebeee) to head (3d6ccfa).
Report is 1 commits behind head on release/v2_contracts.

Files Patch % Lines
...ty_hub/pool-manager/src/tests/integration_tests.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #347      +/-   ##
========================================================
+ Coverage                 89.86%   89.89%   +0.02%     
========================================================
  Files                       261      261              
  Lines                     27339    27342       +3     
========================================================
+ Hits                      24569    24579      +10     
+ Misses                     2770     2763       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xFable
Copy link
Contributor

0xFable commented Apr 29, 2024

🚀

@kerber0x kerber0x merged commit 752bbb1 into release/v2_contracts May 1, 2024
7 checks passed
@kerber0x kerber0x deleted the feat/tweak-queries-pool-manager branch May 1, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants