Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pool-manager max spread assertion #348

Merged
merged 2 commits into from
May 1, 2024

Conversation

kerber0x
Copy link
Contributor

Description and Motivation

Related Issues

This is an issue we solved in the past in V1, but somehow was lingering in V2.


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.91%. Comparing base (deebeee) to head (b75f791).
Report is 2 commits behind head on release/v2_contracts.

❗ Current head b75f791 differs from pull request most recent head 05d5afc. Consider uploading reports for the commit 05d5afc to get more accurate results

Files Patch % Lines
...ontracts/liquidity_hub/pool-manager/src/helpers.rs 50.00% 6 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #348      +/-   ##
========================================================
+ Coverage                 89.86%   89.91%   +0.04%     
========================================================
  Files                       261      261              
  Lines                     27339    27334       -5     
========================================================
+ Hits                      24569    24576       +7     
+ Misses                     2770     2758      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x requested a review from nseguias as a code owner May 1, 2024 10:14
@kerber0x kerber0x merged commit 9cb4af9 into release/v2_contracts May 1, 2024
5 checks passed
@kerber0x kerber0x deleted the fix/spread_assertion branch May 1, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants