Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pool manager cleanup #350

Merged
merged 8 commits into from
May 3, 2024

Conversation

kerber0x
Copy link
Contributor

@kerber0x kerber0x commented May 2, 2024

Description and Motivation

This does some refactoring, general cleanup, adding docs and so on.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 94.57901% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 90.55%. Comparing base (0f77427) to head (5e487cc).
Report is 1 commits behind head on release/v2_contracts.

Files Patch % Lines
...ontracts/liquidity_hub/pool-manager/src/helpers.rs 70.93% 25 Missing ⚠️
...ontracts/liquidity_hub/pool-manager/src/queries.rs 87.03% 7 Missing ⚠️
...quidity_hub/pool-manager/src/liquidity/commands.rs 91.42% 3 Missing ⚠️
...acts/liquidity_hub/pool-manager/src/tests/suite.rs 89.65% 3 Missing ⚠️
...ty_hub/pool-manager/src/tests/integration_tests.rs 99.60% 2 Missing ⚠️
...ntracts/liquidity_hub/pool-manager/src/contract.rs 97.05% 1 Missing ⚠️
...liquidity_hub/pool-manager/src/manager/commands.rs 95.00% 1 Missing ⚠️
contracts/liquidity_hub/pool-manager/src/math.rs 0.00% 1 Missing ⚠️
.../liquidity_hub/pool-manager/src/router/commands.rs 95.45% 1 Missing ⚠️
...ts/liquidity_hub/pool-manager/src/swap/commands.rs 96.42% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #350      +/-   ##
========================================================
+ Coverage                 90.09%   90.55%   +0.45%     
========================================================
  Files                       278      276       -2     
  Lines                     29604    29921     +317     
========================================================
+ Hits                      26673    27095     +422     
+ Misses                     2931     2826     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x marked this pull request as ready for review May 3, 2024 16:04
@kerber0x kerber0x merged commit 2153491 into release/v2_contracts May 3, 2024
7 checks passed
@kerber0x kerber0x deleted the refactor/pool-manager-cleanup branch May 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant