Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commands.rs #378

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Update commands.rs #378

merged 2 commits into from
Aug 30, 2024

Conversation

nick134-bit
Copy link
Collaborator

Description and Motivation

Related Issues

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

kerber0x
kerber0x previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@kerber0x kerber0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kerber0x kerber0x marked this pull request as ready for review August 30, 2024 14:11
nseguias
nseguias previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@nseguias nseguias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure all checks are passing though.

@nick134-bit nick134-bit dismissed stale reviews from nseguias and kerber0x via 0157468 August 30, 2024 15:04
@nick134-bit nick134-bit force-pushed the simulate-aggregation branch from 0157468 to 995ea3c Compare August 30, 2024 15:09
@kerber0x kerber0x merged commit 18bd015 into White-Whale-Defi-Platform:main Aug 30, 2024
4 of 5 checks passed
@kerber0x kerber0x mentioned this pull request Aug 30, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerber0x kerber0x kerber0x approved these changes

@nseguias nseguias nseguias left review comments

@0xFable 0xFable Awaiting requested review from 0xFable 0xFable is a code owner

@Sen-Com Sen-Com Awaiting requested review from Sen-Com Sen-Com is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick134-bit @nseguias @kerber0x