Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed display issue on close position #540

Conversation

jijicodes
Copy link
Contributor

Description and Motivation

Screenshot 2024-03-06 at 6 41 57 PM

Fixed display issue when the user closes their position on the manage liquidity page.
The issue was causing the entire page to crash.

Related Issues

Resolves #490


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly yarn lint.
  • The project builds and is able to deploy on Netlify yarn build.

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for exquisite-salamander-a1fe5e ready!

Name Link
🔨 Latest commit b4b00ae
🔍 Latest deploy log https://app.netlify.com/sites/exquisite-salamander-a1fe5e/deploys/65e90dc1d4b0c2000865c78c
😎 Deploy Preview https://deploy-preview-540--exquisite-salamander-a1fe5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 1 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nick134-bit nick134-bit self-requested a review March 7, 2024 02:12
@nick134-bit nick134-bit merged commit 80e844c into White-Whale-Defi-Platform:main Mar 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects are not valid as a React child (found: [object Promise]) on Close Position + Claim Rewards
2 participants