resolve #771 #772
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |||||
| <Keyword>Win32Proj</Keyword> | ||||||
| <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion> | ||||||
| <ConfigurationType>Application</ConfigurationType> | ||||||
| <PlatformToolset>v142</PlatformToolset> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| <CharacterSet>Unicode</CharacterSet> | ||||||
| </PropertyGroup> | ||||||
| <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" /> | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,7 +29,7 @@ | |||||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration"> | ||||||
| <ConfigurationType>Application</ConfigurationType> | ||||||
| <UseDebugLibraries>true</UseDebugLibraries> | ||||||
| <PlatformToolset>v142</PlatformToolset> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| <CharacterSet>Unicode</CharacterSet> | ||||||
| </PropertyGroup> | ||||||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'" Label="Configuration"> | ||||||
|
|
@@ -41,7 +41,7 @@ | |||||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration"> | ||||||
| <ConfigurationType>Application</ConfigurationType> | ||||||
| <UseDebugLibraries>false</UseDebugLibraries> | ||||||
| <PlatformToolset>v142</PlatformToolset> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| <WholeProgramOptimization>true</WholeProgramOptimization> | ||||||
| <CharacterSet>Unicode</CharacterSet> | ||||||
| </PropertyGroup> | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -102,14 +102,15 @@ goto :ARGS_LOOP | |||||
|
|
||||||
| :POST_ARGS_LOOP | ||||||
| %MSBUILD% %~dp0\DistroLauncher.sln /t:%_MSBUILD_TARGET% /m /nr:true ^ | ||||||
| /restore ^ | ||||||
|
There was a problem hiding this comment. Use spaces
Suggested change
|
||||||
| /p:Configuration=%_MSBUILD_CONFIG% ^ | ||||||
| /p:Platform=%_MSBUILD_PLATFORM% ^ | ||||||
| /p:AppxBundlePlatforms=%_MSBUILD_APPX_BUNDLE_PLATFORMS% ^ | ||||||
| /p:UseSubFolderForOutputDirDuringMultiPlatformBuild=false | ||||||
|
|
||||||
| if (%ERRORLEVEL%) == (0) ( | ||||||
| echo. | ||||||
| echo Created MSIXBUNDLE in ./Pengwin/AppPackages/Pengwin_<version>_<arch> | ||||||
| echo. | ||||||
| ) | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the automated process to publish the program to the store uses Visual Studio 2022, it is preferable to update the BUILDING.md to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. I'll revert these changes in the next push to this PR.
I'm working on build instructions using VS 2022 and the non-legacy rootfs build repo, but I'm running into unrelated issues with debootstrap failing to successfully install sudo in the rootfs.