Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an rm command #25

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Adding an rm command #25

merged 7 commits into from
Sep 27, 2023

Conversation

gl-yziquel
Copy link
Contributor

  • Attempting to add a totp rm command.
  • Correcting an overzealous templating of add onto rm.

@WhyNotHugo
Copy link
Owner

Oh, it slipped my mind that this wasn't using click. Yeah, I think it would be idea to converge on click and entirely drop the hand-rolled argparse bits.

@WhyNotHugo WhyNotHugo merged commit 5a71b01 into WhyNotHugo:master Sep 27, 2023
@WhyNotHugo
Copy link
Owner

Thanks

@gl-yziquel
Copy link
Contributor Author

Want to open an issue for migration to click ?

@WhyNotHugo WhyNotHugo mentioned this pull request Sep 27, 2023
@WhyNotHugo
Copy link
Owner

See: #26

@gl-yziquel
Copy link
Contributor Author

gl-yziquel commented Sep 27, 2023

Thanks. Another thing that would make me more comfortable would be some validation for arguments. To avoid injection, although that seems to me to be a bit paranoid.

@gl-yziquel gl-yziquel deleted the 24-totp-rm branch September 27, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants