PLATFORM-10852 Fix type mismatch between what is returned by getLinkList (list of arrays that contains non-serializable TitleValue) and what is expected by ParserOutput.
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…List` (list of arrays that contains non-serializable TitleValue) and what is expected by ParserOutput.
peterdevpl
reviewed
Mar 20, 2025
| @@ -219,7 +219,7 @@ private static function executeTag( $input, array $args, Parser $parser, PPFrame | |||
|
|
|||
| // we can remove the templates by save/restore | |||
| if ( $reset['templates'] ?? false ) { | |||
| $saveTemplates = $parserOutput->getLinkList( ParserOutputLinkTypes::TEMPLATE ); | |||
| $saveTemplates = $parserOutput->mTemplates; | |||
There was a problem hiding this comment.
question: are you sure this change doesn't cause deprecation warnings?
I doubt this will be accepted upstream, but I realize there might be no other solution...
There was a problem hiding this comment.
I haven't seen any error logs related to that on my sandbox. All these fields are already accessed to write to them.
I don't think there is another solution to this without modifying MediaWiki.
peterdevpl
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fandom.atlassian.net/browse/PLATFORM-10852
Invalid kind of data was assigned to
mLinksvariable. That caused issues with ParserCache, becauseTitleValuecould not be serialized to JSON.