Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COTECH-506] Default player set for 100% of the traffic. #183

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −126
Open

[COTECH-506] Default player set for 100% of the traffic. #183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c9e891
[COTECH-506] Default player set for 100% of the traffic.
dzawada Aug 23, 2023
c25132d
[COTECH-506] Removed custom code for onScroll
dzawada Sep 5, 2023
4bfaa8b
[COTECH-506] Condition supporting styling for mini-player was removed
dzawada Sep 5, 2023
18c944a
[COTECH-506] Restored unmute button
dzawada Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .../DesktopFloatOnScrollArticleVideoPlayer/DesktopFloatOnScrollArticleVideoPlayer.module.css
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions ...players/DesktopFloatOnScrollArticleVideoPlayer/DesktopFloatOnScrollArticleVideoPlayer.tsx
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/loaders/DesktopArticleVideoLoader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { eligibleForVimeoTakeover, getVimeoTakeoverDetails } from 'loaders/utils
import defineExperiment from '@fandom/pathfinder-lite/experiments/defineExperiment';
import getExperiment from '@fandom/pathfinder-lite/experiments/getExperiment';
import { Experiment } from '@fandom/pathfinder-lite/types';
import checkUserGeo from 'utils/experiments/checkUserGeo';

export { getVideoPlayerVersion } from 'loaders/utils/GetVersion';

Expand Down Expand Up @@ -73,11 +72,6 @@ export const DesktopArticleVideoLoader: React.FC<DesktopArticleVideoLoaderProps>
setPlayer(<VimeoDesktopArticleVideoPlayer vimeoDetails={vimeoTakeoverDetails} />),
);
return;
} else if (currentExperiment?.name === desktopJwFloatOnScrollExperiment?.name && checkUserGeo(['us'])) {
import('experimental/players/DesktopFloatOnScrollArticleVideoPlayer/DesktopFloatOnScrollArticleVideoPlayer').then(
({ default: DesktopFloatOnScrollArticleVideoPlayer }) =>
setPlayer(<DesktopFloatOnScrollArticleVideoPlayer videoDetails={videoDetails} />),
);
} else {
switch (currentExperiment?.name) {
case desktopPauseAfterThreePlaysExperiment.name:
Expand Down
2 changes: 0 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ export { default as JWCanonicalVideoPlayer } from 'jwplayer/players/CanonicalVid

export { default as JWDesktopReskinnedArticleVideoPlayer } from 'experimental/players/DesktopReskinnedArticleVideoPlayer/DesktopReskinnedArticleVideoPlayer';

export { default as DesktopFloatOnScrollArticleVideoPlayer } from 'experimental/players/DesktopFloatOnScrollArticleVideoPlayer/DesktopFloatOnScrollArticleVideoPlayer';

export { default as RedVentureVideoPlayer } from 'jwplayer/players/RedVentureVideoPlayer/RedVentureVideoPlayer';

export { default as YoutubeDesktopArticleVideoPlayer } from 'youtube/players/YoutubeDesktopArticleVideoPlayer';
Expand Down