Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM-10554 Remove diverging paths for CSS sanitization #120

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

slayful
Copy link

@slayful slayful commented Feb 10, 2025

In upstream MW 1.43, there was a change allowing the filter in style.

This only affects Gamepedia wikis right now:

  • When building UCP, we’ve introduced a branch in logic because Gamepedia wikis allowed var and Fandom did not (see: https://fandom.atlassian.net/browse/GPUCP-352).
  • During this upgrade, Fandom branch in logic was not affected by MW 1.43.

We can safely change the Fandom branch in logic to allow filter, in MW 1.39 Upgrade we’ve allowed var on Fandom as we pulled in our MW contribution: https://phabricator.wikimedia.org/T288201, so I’d rather remove this branch in logic altogether. That will reduce unnecessary complexity and address the issue.

This reverts commit c47b14f which introduces the branches in logic, making filter correctly work on all wikis.

@slayful slayful merged commit f176fae into REL1_43-Fandom Feb 13, 2025
@slayful slayful deleted the PLATFORM-10554 branch February 13, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants