Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Commit

Permalink
Merge branch 'dev' into XW-4301
Browse files Browse the repository at this point in the history
  • Loading branch information
bkoval authored Nov 27, 2017
2 parents 02fcdc1 + 456e88f commit 70e2131
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 48 deletions.
7 changes: 0 additions & 7 deletions app/components/article-media-map-thumbnail.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {inject as service} from '@ember/service';
import Component from '@ember/component';
import {track, trackActions} from '../utils/track';
import RenderComponentMixin from '../mixins/render-component';

export default Component.extend(RenderComponentMixin, {
Expand All @@ -19,12 +18,6 @@ export default Component.extend(RenderComponentMixin, {
if (url) {
this.get('logger').debug('Handling map with id:', id, 'and title:', title);

track({
action: trackActions.click,
category: 'map',
label: 'open'
});

this.get('openLightbox')('map', {
id,
title,
Expand Down
19 changes: 0 additions & 19 deletions app/controllers/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@ import Controller, {inject as controller} from '@ember/controller';
import MediaModel from '../models/media';
import AlertNotificationsMixin from '../mixins/alert-notifications';
import NoScrollMixin from '../mixins/no-scroll';
import ConnectionTypeMixin from '../mixins/connection-type';
import {track, trackActions} from '../utils/track';

export default Controller.extend(
AlertNotificationsMixin,
NoScrollMixin,
ConnectionTypeMixin,
{
// This has to be here because we need to access media from ArticleController model to open
// lightbox TODO: Should be refactored when decoupling article from application
Expand Down Expand Up @@ -58,23 +55,7 @@ export default Controller.extend(
language: this.get('wikiVariables.language')
});

// This event is for tracking mobile sessions between Mercury and WikiaMobile
// NOTE: this event won't have additional dimensions set up from API, ie. #19 (articleType)
track({
action: trackActions.impression,
category: 'app',
label: 'load'
});

this._super();

if (this.get('effectiveConnectionType')) {
track({
action: trackActions.view,
category: 'connection-type',
label: this.get('effectiveConnectionType')
});
}
},

actions: {
Expand Down
15 changes: 0 additions & 15 deletions app/mixins/connection-type.js

This file was deleted.

7 changes: 1 addition & 6 deletions config/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = function (environment) {
},
weppy: {
enabled: false,
host: 'http://speed.wikia.net/__rum',
host: 'https://speed.nocookie.net/__rum',
samplingRate: 0.1,
aggregationInterval: 1000
},
Expand All @@ -46,11 +46,6 @@ module.exports = function (environment) {
id: 'UA-32129071-1',
sampleRate: 100
},
special: {
prefix: 'special',
id: 'UA-32132943-1',
sampleRate: 100
},
scriptUrl: 'https://www.google-analytics.com/analytics.js'
},
quantcast: {
Expand Down
2 changes: 1 addition & 1 deletion mirage/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default function () {
this.passthrough('https://services.wikia.com/**');
this.passthrough('/wikia.php');
this.passthrough('/api.php');
this.passthrough('http://speed.wikia.net/**');
this.passthrough('https://speed.nocookie.net/**');

// We have /front/main/assets prefix hardcoded in route and testem use /assets
// This is a quick (hopefully temporary) fix
Expand Down

0 comments on commit 70e2131

Please sign in to comment.