Unit testing #716
Merged
Unit testing #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanyaStere42
reviewed
Sep 4, 2024
src/test/README.md
Outdated
|
|
||
| ## JUnit for Unit Testing | ||
|
|
||
| Wildbook uses [JUnit 5](https://junit.org/junit5/docs/current/user-guide/) for unit testing. All unit tests _must run and pass_ in order for changes to be |
TanyaStere42
reviewed
Sep 4, 2024
src/test/README.md
Outdated
| Tests should be created under the `src/test/java/org/ecocean/` directories, corresponding to the java class which are testing. The test class name should follow | ||
| the convention of adding the suffix `Test` to the java class name, such as `AnnotationTest.java` for tests of code within `Annotation.java`. | ||
|
|
||
| Ultimately, almost all Wildbook java classes will have a corresponding `*Test.java` class. If one does not exist to add new tests to, it should be created |
There was a problem hiding this comment.
Ultimately Eventually
"That being said, edits to existing classes may not require full understanding of a class, while testing does. If you choose not to make a unit test for an existing class, make a note of that choice in the PR and explain why."
TanyaStere42
reviewed
Sep 4, 2024
src/test/README.md
Outdated
|
|
||
| ## Integration Testing, Frontend Testing | ||
|
|
||
| TBD / linked elsewhere |
There was a problem hiding this comment.
TODO TBD / linked elsewhere
TanyaStere42
requested changes
Sep 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate unit testing with JUnit 5
pom.xmllibrary updates and changes for maven to run testsAnnotationTest.java