Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve picture book lookup, limits, and description #757

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Improve picture book lookup, limits, and description #757

merged 2 commits into from
Sep 13, 2024

Conversation

JasonWildMe
Copy link
Contributor

pictureBook.jsp:

  • did not check every relevant field for tissue samples and satellite tags but rather only looked at legacy dynamic properties
  • mislabeled Encounter.alternateID as "Nickname"
  • did not mention that listed encounters were limited to N-most recent

Changes

  • Improved description in pictureBook.jsp
  • Improved checks to support dynamic properties (legacy) and TissueSample and SatelliteTag data objects (newer, preferred)
  • Changed Encounter "Nickname" coulmn to "Alternate ID" (often field IDs)

@JasonWildMe JasonWildMe self-assigned this Sep 12, 2024
naknomum
naknomum approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TanyaStere42 TanyaStere42 changed the base branch from master to dev10.4 September 13, 2024 14:00
@TanyaStere42 TanyaStere42 merged commit 99fb5c3 into dev10.4 Sep 13, 2024
1 check passed
@TanyaStere42 TanyaStere42 deleted the pictureBook-qol-improvements branch September 13, 2024 14:00
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
@TanyaStere42
Merge pull request WildMeOrg#757 from WildMeOrg/pictureBook-qol-impro…
7351db5 
…vements

Improve picture book lookup, limits, and description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naknomum naknomum naknomum approved these changes

Assignees

@JasonWildMe JasonWildMe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonWildMe @naknomum @TanyaStere42 @holmbergius