Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

647 session warning react #773

Merged
merged 6 commits into from
Sep 23, 2024
Merged

647 session warning react #773

merged 6 commits into from
Sep 23, 2024

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Sep 18, 2024

implement same session expire warning as jsp pages.

some points worth noting:

  1. when countdown ends, the page shows user is logged out, and was prompted to login again, actually user is not logged out, the session expire warning is not tied with actual tomcat user session
  2. even if the user remains active on the page, when the set time is reached, the modal will still appear if the page hasn’t been refreshed during that time. although it's unlikely for a user to stay on the same page for 20 minutes without navigating away.
  3. if the user clicks the close button, the modal will not reappear when the 20 minutes are up, as long as the page isn’t refreshed.

PR fixes issue #647

@erinz2020 erinz2020 self-assigned this Sep 18, 2024
@erinz2020 erinz2020 requested a review from naknomum September 18, 2024 18:25
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TanyaStere42 TanyaStere42 merged commit f27f686 into dev10.4 Sep 23, 2024
1 check passed
@TanyaStere42 TanyaStere42 deleted the 647_session_warning_react branch September 23, 2024 17:45
@erinz2020 erinz2020 linked an issue Sep 23, 2024 that may be closed by this pull request
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout warning does not display on react pages
2 participants