-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move Julia files to IFTPipeline.jl subdirectory #170
base: main
Are you sure you want to change the base?
refactor: move Julia files to IFTPipeline.jl subdirectory #170
Conversation
6f53391
to
3797150
Compare
934c537
to
6a0c594
Compare
I appreciate the intention behind the proposed changes! However, I have some concerns about moving the core package files to a subfolder. If we intend to publish this package to a registry (such as the Julia Registry for greater visibility), it’s essential that the core code files, README, Project.toml, supporting documentation, and License files remain at the root of the repository. This is a standard convention in the Julia ecosystem to ensure proper visibility and accessibility for users and registries alike. Even if we don’t plan to add this project to a registry, pointing to a subfolder can complicate the installation process. Users would need to navigate to the repository page, click on the folder containing the code, and then copy the link to that folder. Alternatively, they would have to clone the entire repository and specify a subfolder for installation, which adds unnecessary complexity. I believe these drawbacks outweigh the benefit of reducing the number of items in the root directory. What are your thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
Thanks for the feedback!
The repo It was really difficult for me to understand what was related and what could be ignored, and making this move helped me start to draw the boundaries between the different components. I think I understand now which Project.toml file is to be used for which thing. Partitioning the code more cleanly is a necessary shim for the refactoring I'm doing. Whether once we've refactored and tested the code we move it back so it's more Julian is a different question. I'm happy to put that in as an issue.
I don't think users beyond the research group are going to be using this version, because it's so hard to get the Python dependencies working, and it's not been really tested yet. I think we need to provide Docker images which can deal with the complicated Conda dependencies. I'd be happy to refactor it again later to help those users. It looks like Pkg supports Some more things to think about, and let's assume that we keep the original structure
Here are the options I think we need to decide between (in my descending order of preference):
|
…julia-package-in-new-directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live with a subdirectory for now (because it helps me organize my thoughts around this code, and I'm doing the refactoring), and restructure again in future to something which is a bit more Julian
I don't mind taking a temporary measure to facilitate development. Thanks!
... to help clean up the repository. The goal is to have neatly separated directories with:
The CLI file is intentionally ignored here, and will be moved and refactored in #174
Part of: