Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: save labeled segmentations rather than binary segmentations #193
base: jghrefactor/A2f-add-single-file-versions-of-cli-hdf5files
Are you sure you want to change the base?
feature: save labeled segmentations rather than binary segmentations #193
Changes from all commits
69991da
cc12dfc
17318bc
caca865
c9f6f46
617dac1
211991f
1656f56
d815d87
1597b4a
3d5f053
8bf8a24
4d06328
9cc594b
8e24794
d932c5e
16d8fa6
5dd478f
1296d75
973a454
9dadb45
ce505e8
89bc5fc
9f18d78
1adcbf3
5496c84
1f9af06
4ae04f8
753d0fa
739e294
d6b6ca4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggests you might not be using a formatter. We've been using
blue
for Julia files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this to #197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that change helps the reader understand the meaning of the test. The test as it is right now says "the eltypes of the images should be the same" whereas you're suggesting something which I'd read as "the eltype of the uncasted image should be the same as the element type of the argument to the function we're in" – which although being essentially the same thing, makes you have to think one level more abstractly when parsing the test.