feat: update SOIT to allow specifying a path to the outfile #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollandjg
changed the base branch from
main
to
jghrefactor/C-update-soit-to-use-pipx
cpaniaguam
requested changes
Dec 16, 2024
| outpath_ = pathlib.Path(outpath) | ||
|
|
||
| if outpath_.is_dir(): | ||
| filename = outpath_ / pathlib.Path(f"passtimes_lat{lat}_lon{lon}_{''.join(startdate)}_{''.join(enddate)}.csv") |
There was a problem hiding this comment.
This line is a bit too busy and long. Care to split it up into two or more lines?
There was a problem hiding this comment.
Sure, how about this?
cpaniaguam
approved these changes
Dec 17, 2024
hollandjg
deleted the
jghrefactor/C2-update-soit-to-have-configurable-outpath
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the way the other modules work.