Fixed small bugs and corner cases

payment/api/idpay.go

@@ -19,6 +19,12 @@ func (api *API) CreateTransaction(c *gin.Context) {
 		return
 	}
 	logger := log.WithField("body", body)
+	// If buying goods is zero, something's up...
+	if len(body.BuyingGoods) == 0 {
+		logger.Warn("empty buying_goods")
+		c.JSON(http.StatusBadRequest, "empty buying_goods")
+		return
+	}
 	// Try to get the list of goods from database. This will fail if user has bought something
 	// from its BuyingGoods before
 	goods, err := api.Database.GetGoodsFromName(body.BuyingGoods)

payment/pkg/util/rng.go

@@ -2,12 +2,12 @@ package util
 
 import (
 	"crypto/rand"
-	"encoding/base64"
+	"encoding/base32"
 )
 
 // RandomID generates a random ID based on 8 bytes in base 64
 func RandomID() string {
 	buffer := make([]byte, 8)
 	_, _ = rand.Read(buffer)
-	return base64.StdEncoding.EncodeToString(buffer)
+	return base32.StdEncoding.EncodeToString(buffer)
 }