Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowedips: Increase stack size #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allowedips: Increase stack size #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/allowedips.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ static void push_rcu(struct allowedips_node **stack,
struct allowedips_node __rcu *p, unsigned int *len)
{
if (rcu_access_pointer(p)) {
WARN_ON(IS_ENABLED(DEBUG) && *len >= 128);
WARN_ON(IS_ENABLED(DEBUG) && *len >= 128 + 1);
stack[(*len)++] = rcu_dereference_raw(p);
}
}

static void root_free_rcu(struct rcu_head *rcu)
{
struct allowedips_node *node, *stack[128] = {
struct allowedips_node *node, *stack[128 + 1] = {
container_of(rcu, struct allowedips_node, rcu) };
unsigned int len = 1;

Expand All @@ -60,7 +60,7 @@ static void root_free_rcu(struct rcu_head *rcu)

static void root_remove_peer_lists(struct allowedips_node *root)
{
struct allowedips_node *node, *stack[128] = { root };
struct allowedips_node *node, *stack[128 + 1] = { root };
unsigned int len = 1;

while (len > 0 && (node = stack[--len])) {
Expand All @@ -77,11 +77,11 @@ static void walk_remove_by_peer(struct allowedips_node __rcu **top,
#define REF(p) rcu_access_pointer(p)
#define DEREF(p) rcu_dereference_protected(*(p), lockdep_is_held(lock))
#define PUSH(p) ({ \
WARN_ON(IS_ENABLED(DEBUG) && len >= 128); \
WARN_ON(IS_ENABLED(DEBUG) && len >= 128 + 1); \
stack[len++] = p; \
})

struct allowedips_node __rcu **stack[128], **nptr;
struct allowedips_node __rcu **stack[128 + 1], **nptr;
struct allowedips_node *node, *prev;
unsigned int len;

Expand Down