-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding wait_until_ready.py On Behalf of Google #880
base: master
Are you sure you want to change the base?
Conversation
Thank you John for sharing the script. |
Yes correct, run manually(By Bill Ingram) after or before a test to make certain the SAS is fully reset. |
Perfect, thank you! |
I'm mildly in favor of making this an official part of the test harness (but not releasing a new version just for this) since it's being used by ITS as part of their lab testing. Does anyone prefer that we not merge it? |
Recently, we switched from manually executing this script to automatically executing this script after each test. |
Yes Justin(See Above) is actually correct, sorry I didn't know about that change(4/18/19). |
Thank you John and Justin. may I ask you to share the modif you made on test harness code to make the execution automatic, like this we have an idea about it? |
Yes we'll discuss that at ITS and try to have an answer before the meeting today. |
There is some implementation-specific logic in this script but not too much (I think most timeouts would show up as HTTP errors). But I'm OK not to merge since everyone can see it anyway via this PR. |
Requesting wait_until_ready.py be added to TH as discussed during meeting today. Justin Haze made one small verbose change on lines 76-77 from Google's original provided script:
Line 76: #conn.setopt(conn.VERBOSE, 3) # Improve readability.
Line 77: conn.setopt(conn.VERBOSE, False)
Also please do not merge into master, and/or close this PR, if this wait_until_ready.py script should not be in the TH.