-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker script #20
base: main
Are you sure you want to change the base?
Docker script #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks super cool!
However, run_simulation.md
is failing although it previously worked in the other docker setup. I tested adding the missing dependencies and modifying file paths (mentioned in my other comments) but it is still its failing. This should be fixed along with the other comments I've added before this is merged to main
### End ############################################################## | ||
###################################################################### | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add:
RUN rosdep update
RUN rosdep install --from-paths src --ignore-src --rosdistro noetic -y --skip-keys libfranka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we volume the NIST folder, it would not show up during the image building process. It would only show in the docker run or docker execute. So user should do rosdep inside of the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just take out all instructions for running the old way to avoid confusion. It will help us avoid having to maintain 2 different ways to run things. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree. This docker can be used as a alternative or for someone interests to dive in. It would be better to separate it with the main thread.
The zsh and regular does not work well in the realtime environment. The c++ realtime library keeps making errors in the regular user even if the user has been added to the realtime group. The link to the docker-script has been moved to the first item of setup.md/Note |
add a module to use bash script to config and set up docker container. Note: This container uses zsh instead of bash, so you should
source devel/setup.zsh
instead ofsource devel/setup.bash