refactor : Default값 제거

WithPeace · Apr 22, 2024 · cd4d0a3 · cd4d0a3
1 parent 5ace067
commit cd4d0a3
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 8 deletions.
diff --git a/...src/main/java/com/withpeace/withpeace/core/network/di/response/post/PostDetailResponse.kt b/...src/main/java/com/withpeace/withpeace/core/network/di/response/post/PostDetailResponse.kt
@@ -13,5 +13,5 @@ data class PostDetailResponse(
     val type: PostTopicResponse,
     val createDate: String,
     val postImageUrls: List<String>,
-    val comments: List<CommentResponse> = emptyList(),
+    val comments: List<CommentResponse>,
 )
diff --git a/core/ui/src/main/java/com/withpeace/withpeace/core/ui/post/CommentUiModel.kt b/core/ui/src/main/java/com/withpeace/withpeace/core/ui/post/CommentUiModel.kt
@@ -7,18 +7,18 @@ import com.withpeace.withpeace.core.ui.toUiModel
 import java.time.LocalDateTime
 
 data class CommentUiModel(
-    val id: Long = 0,
-    val content: String = "댓글 내용 입니다",
+    val id: Long,
+    val content: String,
     val createDate: DateUiModel = DateUiModel(
         LocalDateTime.now(),
     ),
-    val commentUser: CommentUserUiModel = CommentUserUiModel(),
+    val commentUser: CommentUserUiModel,
 )
 
 data class CommentUserUiModel(
-    val id: Long = 0,
-    val nickname: String = "위드피스",
-    val profileImageUrl: String = "",
+    val id: Long,
+    val nickname: String,
+    val profileImageUrl: String,
 )
 
 fun Comment.toUiModel() = CommentUiModel(

diff --git a/...e/postdetail/src/main/java/com/withpeace/withpeace/feature/postdetail/PostDetailScreen.kt b/...e/postdetail/src/main/java/com/withpeace/withpeace/feature/postdetail/PostDetailScreen.kt
@@ -50,6 +50,7 @@ import com.withpeace.withpeace.core.designsystem.ui.KeyboardAware
 import com.withpeace.withpeace.core.designsystem.ui.WithPeaceBackButtonTopAppBar
 import com.withpeace.withpeace.core.ui.DateUiModel
 import com.withpeace.withpeace.core.ui.post.CommentUiModel
+import com.withpeace.withpeace.core.ui.post.CommentUserUiModel
 import com.withpeace.withpeace.core.ui.post.PostDetailUiModel
 import com.withpeace.withpeace.core.ui.post.PostTopicUiModel
 import com.withpeace.withpeace.core.ui.post.PostUserUiModel
@@ -416,7 +417,18 @@ private fun PostDetailScreenPreview() {
                         LocalDateTime.now(),
                     ),
                     isMyPost = false,
-                    comments = List(10) { CommentUiModel(id = it.toLong()) },
+                    comments = List(10) {
+                        CommentUiModel(
+                            id = it.toLong(),
+                            content = "natum",
+                            createDate = DateUiModel(date = LocalDateTime.now()),
+                            commentUser = CommentUserUiModel(
+                                id = 9807,
+                                nickname = "Becky Lowery",
+                                profileImageUrl = "https://www.google.com/#q=repudiare",
+                            ),
+                        )
+                    },
                 ),
             ),
             lazyListState = rememberLazyListState(),