Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Refactor DeviceCertView #315

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Conversation

rptrchv
Copy link
Contributor

@rptrchv rptrchv commented Jul 11, 2019

Closes #267

@vpetersson vpetersson requested a review from eugenosm July 11, 2019 15:51
Copy link
Contributor

@eugenosm eugenosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short description of code changes

Removes hardcoded urls in models.Device.get_cert_url()
Removes ability to return object for /device-cert/, leave the only crt file result
Add dash url for that view

@@ -104,4 +104,6 @@
api_views.autocomplete_tags,
name='ajax-tags-autocomplete',
),
path('devices/device-cert/<str:device_id>/'.format(api_version), api_views.DeviceCertView.as_view(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format() what function does it perform here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@vpetersson vpetersson merged commit a647852 into WoTTsecurity:master Jul 16, 2019
@rptrchv rptrchv deleted the issue_267 branch July 16, 2019 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor DeviceCertView
4 participants