[CORE] Introduce Support for Folia #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be a starting point for #220 |
|
Roadmap idea:
|
|
UpdateChecker raised as mfnalex/Spigot-UpdateChecker#28 |
Wolfieheart
reviewed
Apr 12, 2023
| @@ -221,7 +221,7 @@ private void commandUpdate(Player player) { | |||
| player.sendMessage(ChatColor.YELLOW + "[ArmorStandEditor] Update Checker will not work on Development Versions."); | |||
| player.sendMessage(ChatColor.YELLOW + "[ArmorStandEditor] Report all bugs to: https://github.com/Wolfieheart/ArmorStandEditor/issues"); | |||
| } else { | |||
| if (plugin.getRunTheUpdateChecker()) { | |||
| if (!Scheduler.isFolia() && plugin.getRunTheUpdateChecker()) { | |||
There was a problem hiding this comment.
Should we foresee a case that:
if(Sheduler.isFolia()){
player.sendMessage(ChatColor.YELLOW + "[ArmorStandEditor] Update Checker does not currently work on Folia .");
player.sendMessage(ChatColor.YELLOW + "[ArmorStandEditor] Report all bugs to: https://github.com/Wolfieheart/ArmorStandEditor/issues");
}
?
Wolfieheart
reviewed
Apr 12, 2023
src/main/resources/plugin.yml
Outdated
| @@ -2,6 +2,7 @@ name: ArmorStandEditor | |||
| main: io.github.rypofalem.armorstandeditor.ArmorStandEditorPlugin | |||
| version: 1.19.4-41 | |||
There was a problem hiding this comment.
Version Bump here and in Pom.xml to 1.19.4-42
Wolfieheart
requested changes
Apr 12, 2023
There was a problem hiding this comment.
SOme comments to be done, but all in all very nice. Also
Something we should add into Readme.md is a badge that had Discord in it: https://discord.gg/3BbJKWpTCj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Folia support.
[CORE] Changes
Changes to the core of the plugin - Performance Fixes, Bug Fixes, New Features, New Permission Nodes, New Config Options etc.
This is what I added on my own server and was afraid to PR due to dropping glowing effect support / update checker
ONLY when running Folia:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the ArmorStandEditor Project Owners have the copyright to use and modify my contribution under the ArmorStandEditor License for perpetuity.