Fix issues in HTTP client #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ending's replacement, add null check for 'content-length' header (WordPress#104)
adamziel
requested changes
Jun 8, 2024
| @@ -230,7 +230,7 @@ function stream_http_prepare_request_bytes( $url ) { | |||
|
|
|||
| // @TODO: Add support for Accept-Encoding: gzip | |||
|
|
|||
| return str_replace( "\n", "\r\n", $request ) . "\r\n\r\n"; | |||
| return $request . "\r\n\r\n"; | |||
There was a problem hiding this comment.
It seems like we'd still get inconsistent newline style depending on where this file was last saved and where is it used. Let's declare each line of the request separately and concatenate them with the \r\n sequence so the result is always the same.
There was a problem hiding this comment.
The newest change introduces single newline style \r\n.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces fixes to the HTTP client as described in #104.
Major Changes:
PHP Notice: Undefined index: content-lengthHow to Test
After checking out to the feature branch, run
blueprint_compiling_simple_progress.phpscript. The script passes all steps connected with downloading and installing WordPress (but still does not complete).Notes
blueprint_compiling_simple_progress.phpscript fails on my machine at step DefineWpConfigConsts, at the moment I'm not sure why, but I'll create a separate issue describing the problem