Default bulk support to true, unless custom Edit is used

WordPress · Nov 27, 2024 · 7fb76cf · 7fb76cf
1 parent 9680521
commit 7fb76cf
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 42 deletions.
diff --git a/packages/dataviews/src/normalize-fields.ts b/packages/dataviews/src/normalize-fields.ts
@@ -64,6 +64,12 @@ export function normalizeFields< Item >(
 			);
 		};
 
+		let supportsBulk = true;
+		// If custom Edit component is passed in we default to false for bulk edit support.
+		if ( typeof field.Edit === 'function' || field.supportsBulk ) {
+			supportsBulk = field.supportsBulk ?? false;
+		}
+
 		const render =
 			field.render || ( field.elements ? renderFromElements : getValue );
 
@@ -76,7 +82,7 @@ export function normalizeFields< Item >(
 			sort,
 			isValid,
 			Edit,
-			supportsBulk: field.supportsBulk ?? false,
+			supportsBulk,
 			enableHiding: field.enableHiding ?? true,
 			enableSorting: field.enableSorting ?? true,
 		};

diff --git a/packages/edit-site/src/components/post-edit/index.js b/packages/edit-site/src/components/post-edit/index.js
@@ -22,13 +22,26 @@ import { unlock } from '../../lock-unlock';
 
 const { PostCardPanel, usePostFields } = unlock( editorPrivateApis );
 
-const fieldsWithBulkEditSupport = [
-	'title',
-	'status',
-	'date',
-	'author',
-	'comment_status',
-];
+const DATAFORM_CONFIG = {
+	type: 'panel',
+	fields: [
+		{
+			id: 'featured_media',
+			layout: 'regular',
+		},
+		'title',
+		{
+			id: 'status',
+			label: __( 'Status & Visibility' ),
+			children: [ 'status', 'password' ],
+		},
+		'author',
+		'date',
+		'slug',
+		'parent',
+		'comment_status',
+	],
+};
 
 function PostEditForm( { postType, postId } ) {
 	const ids = useMemo( () => postId.split( ',' ), [ postId ] );
@@ -75,35 +88,6 @@ function PostEditForm( { postType, postId } ) {
 		[ _fields ]
 	);
 
-	const form = useMemo(
-		() => ( {
-			type: 'panel',
-			fields: [
-				{
-					id: 'featured_media',
-					layout: 'regular',
-				},
-				'title',
-				{
-					id: 'status',
-					label: __( 'Status & Visibility' ),
-					children: [ 'status', 'password' ],
-				},
-				'author',
-				'date',
-				'slug',
-				'parent',
-				'comment_status',
-			].filter(
-				( field ) =>
-					ids.length === 1 ||
-					fieldsWithBulkEditSupport.includes(
-						typeof field === 'string' ? field : field.id
-					)
-			),
-		} ),
-		[ ids ]
-	);
 	const onChange = ( edits ) => {
 		for ( const id of ids ) {
 			if (
@@ -133,7 +117,7 @@ function PostEditForm( { postType, postId } ) {
 			<DataForm
 				data={ ids.length === 1 ? record : records }
 				fields={ fields }
-				form={ form }
+				form={ DATAFORM_CONFIG }
 				onChange={ onChange }
 			/>
 		</VStack>

diff --git a/packages/fields/src/fields/author/index.tsx b/packages/fields/src/fields/author/index.tsx
@@ -15,7 +15,6 @@ const authorField: Field< BasePostWithEmbeddedAuthor > = {
 	id: 'author',
 	type: 'integer',
 	elements: [],
-	supportsBulk: true,
 	render: AuthorView,
 	sort: ( a, b, direction ) => {
 		const nameA = a._embedded?.author?.[ 0 ]?.name || '';

diff --git a/packages/fields/src/fields/date/index.tsx b/packages/fields/src/fields/date/index.tsx
@@ -15,7 +15,6 @@ const dateField: Field< BasePost > = {
 	type: 'datetime',
 	label: __( 'Date' ),
 	render: DateView,
-	supportsBulk: true,
 };
 
 /**

diff --git a/packages/fields/src/fields/status/index.tsx b/packages/fields/src/fields/status/index.tsx
@@ -20,7 +20,6 @@ const statusField: Field< BasePost > = {
 	elements: STATUSES,
 	render: StatusView,
 	Edit: 'radio',
-	supportsBulk: true,
 	enableSorting: false,
 	filterBy: {
 		operators: [ OPERATOR_IS_ANY ],

diff --git a/packages/fields/src/fields/title/index.ts b/packages/fields/src/fields/title/index.ts
@@ -19,7 +19,6 @@ const titleField: Field< BasePost > = {
 	getValue: ( { item } ) => getItemTitle( item ),
 	render: TitleView,
 	enableHiding: false,
-	supportsBulk: true,
 };
 
 export default titleField;