Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Loop block: remove 'add new post' prompt in the sidebar #67189

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dhruvang21
Copy link
Contributor

Fixes:- #67177

What?

This PR removes the "Add New Post" link in the Query Loop block's description.

Why?

The "Add New Post" link in the Query Loop block directs users to the post editor. While its intent is to guide users to create posts for an empty Query Loop block, it disrupts the user's workflow by taking them away from the editor. This leads to potential confusion as users may not know how to return and continue working on the Query Loop block. Removing the link ensures a more seamless experience.

How?

The link has been removed from the Query Loop block's description. This adjustment ensures that users are not redirected away from their current editing context.

Testing Instructions

  1. Open a post or page.
  2. Insert a query loop block.
  3. Observe that the "Add New Post" link is no longer present in the block's description.

Screenshots or screencast

image

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Nov 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvang21 <[email protected]>
Co-authored-by: annezazu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dhruvang21
Copy link
Contributor Author

dhruvang21 commented Nov 21, 2024

I haven’t deleted the create-new-post-link.js file yet, as I believe removing it would require proper documentation or mentioning it in the changelog. I’m not entirely sure of the exact process, so I’d appreciate guidance from the reviewers. Once clarified, I’ll delete the file in the next commit.

@annezazu
Copy link
Contributor

Just tested! Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants