Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite: Restore Hover and Typeahead functionality #67212

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Composite: Restore Hover and Typeahead functionality #67212

wants to merge 4 commits into from
+7 −6

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 21, 2024 •
edited
Loading

Fixes #67152

What?

Restores functionality of Composite.Hover and Composite.Typeahead.

How?

Due to a copy paste error in #65821, Typeahead functionality was lost and replaced with a CompositeRow, as well as Hover with CompositeGroup 😄

Testing Instructions

See repro instructions in #67152.

@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Nov 21, 2024
@mirka mirka self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: cbravobernal <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: jameskoster <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka mentioned this pull request Nov 21, 2024
Open
mirka
mirka commented Nov 21, 2024
View reviewed changes
packages/components/src/composite/hover.tsx
@@ -26,5 +26,5 @@ export const CompositeHover = forwardRef<
// obfuscated to discourage its use outside of the component's internals.
const store = ( props.store ?? context.store ) as Ariakit.CompositeStore;

return <Ariakit.CompositeGroup store={ store } { ...props } ref={ ref } />;
return <Ariakit.CompositeHover store={ store } { ...props } ref={ ref } />;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol another one

@mirka mirka changed the title Composite.Typeahead: Restore functionality Composite: Restore Hover and Typeahead functionality Nov 21, 2024
@mirka mirka requested review from t-hamano and a team November 21, 2024 17:57
@github-actions GitHub Actions
Copy link

Flaky tests detected in 9a319a3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11958943827
📝 Reported issues:

@t-hamano t-hamano mentioned this pull request Nov 22, 2024
Closed
t-hamano
t-hamano approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have confirmed that both the up and down keyboard navigation and type-ahead functions work correctly.

Before

before.mp4

After

after.mp4

packages/components/CHANGELOG.md
Comment on lines +21 to +23
- `FormFileUpload`: Prevent HEIC and HEIF files from being uploaded on Safari ([#67139](https://github.com/WordPress/gutenberg/pull/67139)).
- `Composite.Hover`: Restore functionality ([#67212](https://github.com/WordPress/gutenberg/pull/67212)).
- `Composite.Typeahead`: Restore functionality ([#67212](https://github.com/WordPress/gutenberg/pull/67212)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these three more appropriate for the bug fixes section?

@t-hamano
Copy link
Contributor

I think this PR is worth backporting to 6.7.2, so I'm adding the "Backport to WP Minor Release" label.

cc @cbravobernal

@t-hamano t-hamano added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@mirka mirka

Labels
Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataViews: Keyboard navigation in filter configuration listbox is broken
2 participants
@mirka @t-hamano