Fix typos #67304

szepeviktor · 2024-11-26T09:04:31Z

What?

Found few years of typos.

How?

Would you like me to work on it?

github-actions · 2024-11-26T09:04:49Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: szepeviktor <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-11-26T09:04:53Z

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions · 2024-11-26T09:04:54Z

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions · 2024-11-26T09:05:08Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @szepeviktor! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Mamaduka · 2024-11-26T11:05:43Z

packages/block-editor/src/components/index.js

@@ -11,7 +11,7 @@ export {
 	BlockAlignmentControl,
 	BlockAlignmentToolbar,
 } from './block-alignment-control';
-export { default as __experimentalBlockFullHeightAligmentControl } from './block-full-height-alignment-control';
+export { default as __experimentalBlockFullHeightAlignmentControl } from './block-full-height-alignment-control';


I believe this was intentionally exported with a typo in the name for backward compatibility. If you check the export below, it has the correct name.

t-hamano

@szepeviktor Thanks for the cleanup.

I think this PR contains a lot of unnecessary changes that need to be fixed and go through all CI. Could you address these issues?

t-hamano · 2024-11-26T12:04:29Z

docs/manifest.json

-		"slug": "undestanding-global-state-local-context-and-derived-state",
+		"slug": "understanding-global-state-local-context-and-derived-state",


I'm concerned that changing this slug may have ramifications for syncing with the Block Editor Handbook.

cc @ndiego @juanmaguitar

t-hamano · 2024-11-26T12:09:33Z

packages/block-editor/src/components/global-styles/filters-panel.js

-		const settedValue = duotonePreset
+		const setValue = duotonePreset


The name setValue is often used as the set function in the useState hook in Gutenberg projects.

To avoid confusion, how about using a different name? For example, duotoneValue.

t-hamano · 2024-11-26T12:13:42Z

packages/components/src/combobox-control/test/index.tsx

-	{ label: 'European Central Time', value: 'ECT' },
+	{ label: 'European Central Time', value: 'ETC' },


This value is an abbreviation for "European Central Time", so no changes should be necessary.

@t-hamano This is a halfdone PR.

So do you give a green light?

Does this mean this PR is still a work in progress? Could you give us more details?

This PR is the result of my default typos config + typos -w (autofix) + some manual work.
I need your confirmation before working on it for an hour or two.

t-hamano · 2024-11-26T12:14:31Z

packages/components/src/surface/test/__snapshots__/index.tsx.snap

-     class="components-surface css-iin9ud-PolymorphicDiv-Surface-getBorders-primary e19lxcc00"
+-     class="components-surface css-in9ud-PolymorphicDiv-Surface-getBorders-primary e19lxcc00"


This change should not be necessary.

t-hamano · 2024-11-26T12:14:48Z

packages/components/src/utils/strings.ts

-			/(?!(?:1ST|2ND|3RD|[4-9]TH)(?![a-z]))([a-z0-9])([A-Z])/g, // fooBar => foo-bar, 3Bar => 3-bar
+			/(?!(?:1ST|2AND|3RD|[4-9]TH)(?![a-z]))([a-z0-9])([A-Z])/g, // fooBar => foo-bar, 3Bar => 3-bar


This change should not be necessary.

t-hamano · 2024-11-26T12:31:52Z

packages/react-native-editor/__device-tests__/helpers/utils.js

-			desiredCaps.udid = androidDeviceID;
+			desiredCaps.uuid = androidDeviceID;


I don't think this can be changed.

t-hamano · 2024-11-26T12:32:01Z

packages/react-native-editor/bin/test-e2e-setup.sh

-	local simulators=$(xcrun simctl list devices -j | jq -r --arg runtime "$runtime_name" '.devices | to_entries[] | select(.key | contains($runtime)) | .value[] | .name + "," + .udid')
+	local simulators=$(xcrun simctl list devices -j | jq -r --arg runtime "$runtime_name" '.devices | to_entries[] | select(.key | contains($runtime)) | .value[] | .name + "," + .uuid')


I don't think this can be changed.

t-hamano · 2024-11-26T12:35:13Z

patches/react-autosize-textarea+7.1.0.patch

@@ -6,8 +6,8 @@ index ad6ff3f..e0a6d51 100644
         lineHeight: number | null;


This change seems to cause a lot of CI failures. I think this file cannot be modified because it is a patch for an external npm library.

t-hamano · 2024-11-26T12:38:21Z

...ste-should-cut-partial-selection-and-merge-like-a-normal-delete---not-forward-2-chromium.txt

-<h2 class="wp-block-heading">ading</h2>
+<h2 class="wp-block-heading">adding</h2>


I think this is intentional, so if we change it the tests should fail.

t-hamano · 2024-11-26T12:38:29Z

...d-paste-plain-text-in-plain-text-context-when-cross-block-selection-is-copied-2-chromium.txt

-<pre class="wp-block-code"><code>ading
+<pre class="wp-block-code"><code>adding


I think this is intentional, so if we change it the tests should fail.

michalczaplinski · 2024-11-26T15:22:10Z

bin/plugin/commands/test/__snapshots__/changelog.js.snap

@@ -221,7 +221,7 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = `
 - Don’t use TypeScript files in scripts package. ([54856](https://github.com/WordPress/gutenberg/pull/54856))
 - ESLint: Update eslint-plugin-testing-library to v6. ([54910](https://github.com/WordPress/gutenberg/pull/54910))
 - Fix end-to-end test: ”WP Editor Meta Boxes > Should save the changes”. ([51884](https://github.com/WordPress/gutenberg/pull/51884))
- Font Library: Avoid deprected error in test. ([54802](https://github.com/WordPress/gutenberg/pull/54802))
+- Font Library: Avoid deprecated error in test. ([54802](https://github.com/WordPress/gutenberg/pull/54802))


The "typos" in this file refer to the original PR names on github so probably cannot be changed.

michalczaplinski

I'd recommend to severely limit the scope of this PR. It's very hard to review and approve 436 typos across 259 files. As previously noted, many of the "typos" are not really typos here at all.

How about starting with just the typos in markdown files and code comments?

szepeviktor · 2024-11-26T17:27:04Z

How about starting with just the typos in markdown files and code comments?

This is a good idea.
Although there are approx. 0 Markdown files involved and Typos works this way: typos -w.
So there is no --do-not-touch-the-code switch.

A) I could close this PR and provide you with my Typos configuration
B) I could work on this PR to remove all false positives

Please decide!

szepeviktor · 2024-11-26T18:00:34Z

I've all I could.

Fix typos

80c4cfc

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 26, 2024

spacedmonkey approved these changes Nov 26, 2024

View reviewed changes

Revert

e5e1faa

Mamaduka reviewed Nov 26, 2024

View reviewed changes

t-hamano requested changes Nov 26, 2024

View reviewed changes

michalczaplinski added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 26, 2024

michalczaplinski reviewed Nov 26, 2024

View reviewed changes

michalczaplinski requested changes Nov 26, 2024

View reviewed changes

Revert all false positives

73cceea

szepeviktor added 2 commits November 26, 2024 18:04

Revert even more false positives

d794037

Revert file rename

2ad2d7e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typos #67304

Fix typos #67304

szepeviktor commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

Mamaduka Nov 26, 2024

t-hamano left a comment

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

szepeviktor Nov 26, 2024

t-hamano Nov 26, 2024

szepeviktor Nov 26, 2024

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

t-hamano Nov 26, 2024

michalczaplinski Nov 26, 2024 •

edited

Loading

michalczaplinski left a comment

szepeviktor commented Nov 26, 2024 •

edited

Loading

szepeviktor commented Nov 26, 2024

		"slug": "undestanding-global-state-local-context-and-derived-state",
		"slug": "understanding-global-state-local-context-and-derived-state",

		const settedValue = duotonePreset
		const setValue = duotonePreset

		{ label: 'European Central Time', value: 'ECT' },
		{ label: 'European Central Time', value: 'ETC' },

		- class="components-surface css-iin9ud-PolymorphicDiv-Surface-getBorders-primary e19lxcc00"
		- class="components-surface css-in9ud-PolymorphicDiv-Surface-getBorders-primary e19lxcc00"

		/(?!(?:1ST\|2ND\|3RD\|[4-9]TH)(?![a-z]))([a-z0-9])([A-Z])/g, // fooBar => foo-bar, 3Bar => 3-bar
		/(?!(?:1ST\|2AND\|3RD\|[4-9]TH)(?![a-z]))([a-z0-9])([A-Z])/g, // fooBar => foo-bar, 3Bar => 3-bar

		desiredCaps.udid = androidDeviceID;
		desiredCaps.uuid = androidDeviceID;

		local simulators=$(xcrun simctl list devices -j \| jq -r --arg runtime "$runtime_name" '.devices \| to_entries[] \| select(.key \| contains($runtime)) \| .value[] \| .name + "," + .udid')
		local simulators=$(xcrun simctl list devices -j \| jq -r --arg runtime "$runtime_name" '.devices \| to_entries[] \| select(.key \| contains($runtime)) \| .value[] \| .name + "," + .uuid')

		@@ -6,8 +6,8 @@ index ad6ff3f..e0a6d51 100644
		lineHeight: number \| null;

		<h2 class="wp-block-heading">ading</h2>
		<h2 class="wp-block-heading">adding</h2>

		<pre class="wp-block-code"><code>ading
		<pre class="wp-block-code"><code>adding

Fix typos #67304

Are you sure you want to change the base?

Fix typos #67304

Conversation

szepeviktor commented Nov 26, 2024 • edited Loading

What?

How?

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

Choose a reason for hiding this comment

t-hamano left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalczaplinski Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

michalczaplinski left a comment

Choose a reason for hiding this comment

szepeviktor commented Nov 26, 2024 • edited Loading

szepeviktor commented Nov 26, 2024

szepeviktor commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

michalczaplinski Nov 26, 2024 •

edited

Loading

szepeviktor commented Nov 26, 2024 •

edited

Loading