Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .components-item-group selector in edit-site components #67384

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Remove .components-item-group selector in edit-site components #67384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce7db31
Style: Remove usage of .components-item-group CSS selector in sidebar…
im3dabasia Nov 28, 2024
f27113e
fix: Renamed classname for the sidebar-navigation-screen-main
im3dabasia Nov 28, 2024
1e92a58
feat: Add horizontal negative margins for navigation, pages, template…
im3dabasia Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-dataviews/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function DataViewsSidebarContent( { postType } ) {

return (
<>
<ItemGroup>
<ItemGroup className="edit-site-sidebar-dataviews">
{ defaultViews.map( ( dataview ) => {
return (
<DataViewItem
Expand Down
5 changes: 5 additions & 0 deletions packages/edit-site/src/components/sidebar-dataviews/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,8 @@
color: $white;
}
}

.edit-site-sidebar-dataviews {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-main/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { store as editSiteStore } from '../../store';

export function MainSidebarNavigationContent() {
return (
<ItemGroup>
<ItemGroup className="edit-site-sidebar-navigation-screen-main">
<SidebarNavigationItem
uid="navigation-navigation-item"
to="/navigation"
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-navigation-menus/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export default function SidebarNavigationScreenNavigationMenus( { backPath } ) {

return (
<SidebarNavigationScreenWrapper backPath={ backPath }>
<ItemGroup>
<ItemGroup className="edit-site-sidebar-navigation-screen-navigation-menus">
{ navigationMenus?.map( ( { id, title, status }, index ) => (
<NavMenuItem
postId={ id }
Expand Down
5 changes: 5 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-screen-navigation-menus/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,8 @@
.edit-site-sidebar-navigation-screen-navigation-menus__helper-block-editor {
display: none;
}

.edit-site-sidebar-navigation-screen-navigation-menus {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}
2 changes: 2 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-screen-patterns/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.edit-site-sidebar-navigation-screen-patterns__group {
margin-bottom: $grid-unit-30;
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;

&:last-of-type {
border-bottom: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-templates-browse/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function DataviewsTemplatesSidebarContent() {
}, [ records ] );

return (
<ItemGroup>
<ItemGroup className="edit-site-sidebar-navigation-screen-templates-browse">
<SidebarNavigationItem
to="/template"
icon={ layout }
Expand Down
4 changes: 4 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-screen-templates-browse/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.edit-site-sidebar-navigation-screen-templates-browse {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
.edit-site-sidebar-navigation-screen__content {
padding: 0 $grid-unit-20;

.components-item-group {
.edit-site-sidebar-navigation-screen-main {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}
Expand Down
1 change: 1 addition & 0 deletions packages/edit-site/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
@import "./components/pagination/style.scss";
@import "./components/global-styles/variations/style.scss";
@import "./components/sidebar-global-styles-wrapper/style.scss";
@import "./components/sidebar-navigation-screen-templates-browse/style.scss";

/* stylelint-disable -- Disable reason: View Transitions not supported properly by stylelint. */
::view-transition-image-pair(root) {
Expand Down
Loading