-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify description and option names in the Lock modal dialog #67437
base: trunk
Are you sure you want to change the base?
Simplify description and option names in the Lock modal dialog #67437
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
In order to resolve the E2E test failure, could you also update the strings Disable movement
and Prevent removal
contained in the following files?
- test/e2e/specs/editor/blocks/columns.spec.js
- test/e2e/specs/editor/various/block-locking.spec.js
- test/e2e/specs/editor/various/block-switcher.spec.js
Thanks for the PR! One of the points from the issue #62843 is that this text is now the legend of a fieldset element. It's too long to be a legend, it would be nice to make it way shorter. What about something along the lines of |
|
@t-hamano I wanted to know whether I should also change the test title string? |
Fixes: #62843
What?
This PR simplifies the description and renames the options in the Lock modal dialog to make the interface clearer and more intuitive for users.
Why?
The original description was too long and confusing, with mismatched visuals and terminology that added cognitive load. Additionally, the varying verbs for options were inconsistent and unnecessary. Simplifying the language and standardizing the option names enhances user understanding.
How?
Testing Instructions
Screenshots or screencast