-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ColorPalette: Add editable hex label support #69230
base: trunk
Are you sure you want to change the base?
ColorPalette: Add editable hex label support #69230
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @dhruvikpatel18, Can you fix the following? Its not updating the input field correctly when switching colors while its in focus. Screen.Recording.2025-02-18.at.7.05.00.PM.mov |
Hi @Mayank-Tripathi32, Thanks for this pointing out. |
Thanks, I will test it again today, Can you also look into the unit tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
- Tested with keyboard navigation
- Tested with invalid inputs
- Tested with changing values in color picker, it says in sync
Closes #57244
What?
Adds the ability to edit hex color values directly in the ColorPalette component without opening the color picker.
Why?
Currently, users need to open the color picker to input a specific hex color value, which adds unnecessary steps when they already know the exact hex code they want to use. This enhancement improves the user experience by allowing direct hex value editing.
How?
CustomColorValueInput
component that handles the editable hex value functionalityTesting Instructions
Screenshots or screencast
Before
Screen.Recording.2025-02-17.at.5.26.09.PM.mov
After
Screen.Recording.2025-02-18.at.12.41.32.PM.mov