-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable end user opt-in to generate all sizes in fallback format #1689
Merged
mukeshpanchal27
merged 20 commits into
WordPress:trunk
from
b1ink0:add/option-to-generate-all-image-sizes
Dec 6, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
95e7878
Add settings for generate fallback images in all sizes. Add functiona…
b1ink0 8473bb8
Add generator tag for tracking usage of generate all fallback image s…
b1ink0 536c799
Merge branch 'WordPress:trunk' into add/option-to-generate-all-image-…
b1ink0 fa34edf
Remove use of empty()
b1ink0 e8460fe
Change the function, option, variable names
b1ink0 39e6004
Merge branch 'trunk' into add/option-to-generate-all-image-sizes
b1ink0 e297363
Merge branch 'add/option-to-generate-all-image-sizes' of https://gith…
b1ink0 6ddd884
Move logic to separate function
b1ink0 b80a9b0
Remove generator tag
b1ink0 d477128
Merge branch 'trunk' into add/option-to-generate-all-image-sizes
b1ink0 9eaaeec
Merge branch 'trunk' into add/option-to-generate-all-image-sizes
b1ink0 4fdbcc0
Fix fallback option retrieval and clean up docblock in webp uploads p…
b1ink0 3a64713
Use existing function for getting option value
b1ink0 546e2d7
Merge branch 'trunk' into add/option-to-generate-all-image-sizes
b1ink0 2747d1b
Merge branch 'trunk' into add/option-to-generate-all-image-sizes
b1ink0 36fbfd7
Update docblock for webp_uploads_should_generate_all_fallback_sizes f…
b1ink0 e29a33e
Add test case for generating fallback images for all sizes option ena…
b1ink0 e4601ae
Merge branch 'trunk' into add/option-to-generate-all-image-sizes
b1ink0 3ed8269
Merge branch 'trunk' into add/option-to-generate-all-image-sizes
b1ink0 10e0c39
Cleanup test attachment after assertions
b1ink0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future request for
<style>
and<script>
tags for individual functions:Currently, for the
<picture>
element, we have added additional CSS and script tags. Can we centralize these in a common location ( Single tag for<style>
and<script>
)? This would ensure that in the future, we don’t need to re-add them in specific callback function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would moving
<style>
and<script>
to files and enqueuing them better option for centralization then?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something we can do in follow-up PR once these one is committed.