Legacy: begin a legacy mode with swapping of hooks (DNM) #92
+842
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces documentation updates for legacy support with a new hook naming scheme and reworks several reference files to support the transition to SCF legacy mode. Key changes include:
- Adding new documentation pages for legacy hooks and block bindings.
- Updating hook names in META.md to incorporate the new "scf" prefix.
- Standardizing file references and list formats across multiple documentation files.
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/code-reference/hooks/action.md | New documentation for ACF hooks with potential legacy implications. |
| docs/code-reference/hooks/filter.md | New documentation for an ACF filter hook. |
| docs/code-reference/admin/views/global/index.md | Header and link format updated for clarity. |
| docs/code-reference/legacy/* | New legacy documentation pages introduced for hook mappings. |
| docs/code-reference/META.md | Updated hook entries to reflect the new SCF naming convention. |
| Other files | Consistent reformatting from dashed to asterisk bullet lists and minor docblock corrections. |
Comments suppressed due to low confidence (3)
docs/code-reference/admin/views/global/index.md:1
- [nitpick] The header 'Global' may be overly generic compared to the previous 'Admin Views Global'; consider using a more descriptive title to maintain context.
# Global
docs/code-reference/acf-helper-functions-file.md:117
- Ensure that updating the return annotation from '@return array' to '@return void' is consistent with the actual function behavior.
* @return void
docs/code-reference/META.md:9
- Verify that all legacy hook names have been updated consistently to use the 'scf' prefix, and confirm that no outdated 'acf' references remain.
+- `scf_bindings_field_not_allowed_message`
kraftbj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As time evolves, SCF is likely to diverge from the ACF parent. Similar to the great renaming in WordPress, SCF should start to move things to a new naming scheme. For backwards compatiblity, I'm thinking of having a "legacy mode". Open to thoughts on the idea in principle and in implementation!
Additionally, need to confirm
scf_is the best prefix moving forward.