Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled Themes Version Bumps for WordPress 6.7 #7564

Closed
wants to merge 21 commits into from

Conversation

SH4LIN
Copy link

@SH4LIN SH4LIN commented Oct 14, 2024

Overview

  • This PR will bumps up the version of the WordPress in themes from twentyten to twentytwentyfour.

Latest theme versions

  • Twenty Ten - 4.3
  • Twenty Eleven: 4.8
  • Twenty Twelve: 4.4
  • Twenty Thirteen: 4.3
  • Twenty Fourteen: 4.1
  • Twenty Fifteen: 3.9
  • Twenty Sixteen: 3.4
  • Twenty Seventeen: 3.8
  • Twenty Nineteen: 3.0
  • Twenty Twenty: 2.8
  • Twenty Twenty-One: 2.4
  • Twenty Twenty-Two: 1.9
  • Twenty Twenty-Three: 1.6
  • Twenty Twenty-Four: 1.3

Trac ticket: https://core.trac.wordpress.org/ticket/62034


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Oct 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sh4lin, peterwilsoncc, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@SH4LIN
Copy link
Author

SH4LIN commented Oct 14, 2024

I haven't updated the changelogs in the readme.txt. as I am not sure what will be the release date of theme

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this.

  1. For the changelogs, the release date is scheduled for November 12, 2024.
  2. Please update version numbers in the package.json and package-lock.json files for Twenty Nineteen, Twenty Twenty and Twenty Twenty-One. See PR 6705.
  3. In themes from Twenty Ten to Twenty Seventeen, update the CSS and JS version strings in functions.php (and/or header.php) only if the file has changed since the last release. Main style.css stylesheets reflect the scheduled release date (20241112), and others use the modified date. Almost all blocks.css and editor-blocks.css files have been updated, but only one ie.css stylesheet and none of the JS files should change their version at this time.
Theme/File Version
twentyten/blocks.css 20240703
twentyten/editor-blocks.css 20240703
twentyeleven/blocks.css 20240703
twentyeleven/editor-blocks.css 20240716
twentytwelve/blocks.css 20240812
twentytwelve/editor-blocks.css 20240811
twentytwelve/ie.css 20240722
twentythirteen/editor-blocks.css 20240716
twentyfourteen/blocks.css 20240708
twentyfourteen/editor-blocks.css 20240716
twentyfifteen/blocks.css 20240715
twentyfifteen/editor-blocks.css 20240720
twentysixteen/blocks.css 20240817
twentysixteen/editor-blocks.css 20240817
twentyseventeen/blocks.css 20240729
twentyseventeen/editor-blocks.css 20240824

@SH4LIN
Copy link
Author

SH4LIN commented Oct 17, 2024

@sabernhardt Got it, I’ll make the changes as requested.

@SH4LIN SH4LIN requested a review from sabernhardt October 20, 2024 12:35
@SH4LIN
Copy link
Author

SH4LIN commented Oct 20, 2024

@sabernhardt I have made all the changes.

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more edit, please :)


// Theme block stylesheet.
wp_enqueue_style( 'twentythirteen-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentythirteen-style' ), '20240520' );
wp_enqueue_style( 'twentythirteen-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentythirteen-style' ), '20231016' );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wp_enqueue_style( 'twentythirteen-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentythirteen-style' ), '20231016' );
wp_enqueue_style( 'twentythirteen-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentythirteen-style' ), '20240520' );

The most recent change to blocks.css was r58178 on May 20, 2024.

@SH4LIN
Copy link
Author

SH4LIN commented Oct 25, 2024

@sabernhardt Done

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@peterwilsoncc peterwilsoncc changed the title Bundled Themes Version Bumps for WordPress 6.6 Bundled Themes Version Bumps for WordPress 6.7 Nov 4, 2024
@peterwilsoncc
Copy link
Contributor

Merged r59344 / d897aad

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants