Admin: Update admin notices to use 'notice notice-error' class #7800
Conversation
Replaces legacy 'error' class with 'notice notice-error' in admin error notices for consistency with WordPress standards.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-signup.php
Outdated
| @@ -131,7 +131,7 @@ function show_blog_form( $blogname = '', $blog_title = '', $errors = '' ) { | |||
| $errmsg_blogname_aria = ''; | |||
| if ( $errmsg_blogname ) { | |||
| $errmsg_blogname_aria = 'wp-signup-blogname-error '; | |||
| echo '<p class="error" id="wp-signup-blogname-error">' . $errmsg_blogname . '</p>'; | |||
| echo '<p class="notice notice-error" id="wp-signup-blogname-error">' . $errmsg_blogname . '</p>'; | |||
There was a problem hiding this comment.
In wp-signup.php, these classes are defined in the wpmu_signup_stylesheet function added to wp_head. They aren't part of the WP Admin style group. While we could change the styles in the function, removing the .error class is likely to break custom styles implemented by sites. Should probably revert this change and go back to .error in this file.
There was a problem hiding this comment.
In keeping with the original purpose of the ticket, however, do remove font-weight: 600 from the .mu_register .error class.
|
@joedolson , I have removed the changes related to the back-compat files. Please let me know if you have any further feedback or suggestions for improvements. |
|
Thanks, @im3dabasia! Still need to update the error classes used in |
src/wp-signup.php
Outdated
| @@ -131,7 +131,7 @@ function show_blog_form( $blogname = '', $blog_title = '', $errors = '' ) { | |||
| $errmsg_blogname_aria = ''; | |||
| if ( $errmsg_blogname ) { | |||
| $errmsg_blogname_aria = 'wp-signup-blogname-error '; | |||
| echo '<p class="error" id="wp-signup-blogname-error">' . $errmsg_blogname . '</p>'; | |||
| echo '<p class="notice notice-error" id="wp-signup-blogname-error">' . $errmsg_blogname . '</p>'; | |||
There was a problem hiding this comment.
In keeping with the original purpose of the ticket, however, do remove font-weight: 600 from the .mu_register .error class.
Trac ticket: https://core.trac.wordpress.org/ticket/50402
This PR addresses by updating admin error notices to use the
notice notice-errorclasses instead of the legacyerrorclass. This change aligns error notice styling with current WordPress standards and improves visual consistency across the admin interface.