Only prime salt options early once #7842
Open
+26
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is pushed for testing purposes, currently is incomplete.
This adds a check to see if
wp_salt()
related options have already been primed before attempting to prime them again. This is necessary because thewp_salt()
function can be called multiple times during the bootstrap process, and we need to ensure that the options are only primed once.This also avoids an error that can occur if the salt related constants are defined after the first time
wp_salt()
is called, in which case the salt will not be present in the$duplicated_keys
array.Trac ticket: https://core.trac.wordpress.org/ticket/62424
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.