Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Block Name" to "Plugin Name" #23

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

StevenDufresne
Copy link

When I try to include a newly made block directly into an environment, it doesn't work because it's looking for "Plugin Name".

I'm not certain this happens in all environments but it's definitely happening when I include it in the plugin section in .wp-env.json.

Is there any reason why we can't change it to Plugin Name:?

Here's an example of what I do:

{
	"plugins": [
		...
		"../wporg-mu-plugins/mu-plugins/blocks/new-block-name"
	],
}

@ryelle
Copy link
Contributor

ryelle commented Aug 22, 2022

I used "Block Name" since this template isn't generating standalone plugins, but blocks that live inside wporg-mu-plugins/mu-plugins/blocks/. If you're creating a standalone plugin, I'd stick with the default template from @wordpress/create-block.

@StevenDufresne
Copy link
Author

I used "Block Name" since this template isn't generating standalone plugins, but blocks that live inside wporg-mu-plugins/mu-plugins/blocks/. If you're creating a standalone plugin, I'd stick with the default template from @wordpress/create-block.

Isn't a block technically a standalone plugin, or at least should be conceived as such? If we were to submit it to the block directory, would we need to change it to "Plugin Name"? What does keeping it as "Block Name" give us?

@ryelle
Copy link
Contributor

ryelle commented Aug 25, 2022

Isn't a block technically a standalone plugin, or at least should be conceived as such?

It could be, but this template isn't designed for that.

If we were to submit it to the block directory, would we need to change it to "Plugin Name"?

We would also need to replace the readme, since it details wporg-mu-plugin setup. So if anything, keeping "Block Name" would remind us to check the whole block. But I don't think we want the source-of-truth for a wp.org repo plugin to be in wporg-mu-plugins. I'd rather have that in its own repo so we can use specific GH actions. The default template from @wordpress/create-block is much better set up for creating a plugin we want to share on w.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants