Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement only_transcription and only_diarization #261

Merged
merged 15 commits into from
Oct 4, 2023
Merged

Implement only_transcription and only_diarization #261

merged 15 commits into from
Oct 4, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Oct 2, 2023 •
edited
Loading

This PR:

  • Simplify the endpoints added to the asr_type
  • Added the transcription_endpoint and diarization_endpoint
  • Fix the dependencies of the project by moving inference to core dependencies.
  • Define the ASRTranscriptionOnly for the only_transcription asr type.
  • Define the ASRDiarizationOnly for the only_diarization asr type.
  • Removed the clueless Word model to use the one from faster-whisper.
  • Updated how endpoints are added.
  • Updated the TranscribeService to handle audio formatted as TensorShare object for remote execution case.
  • Corrected the read_audio method to raise a ValueError if the input type is not matched.

Fixes #259 and #260

@chainyo chainyo linked an issue Oct 2, 2023 that may be closed by this pull request
Implement only_transcription #259
Closed
@chainyo chainyo added api Everything related to the API implementation transcription Everything related to the transcription part labels Oct 2, 2023
@chainyo chainyo added the diarization Everything related to the diarization part label Oct 3, 2023
@chainyo chainyo changed the title Implement only transcription Implement only_transcription and only_diarization Oct 3, 2023
@chainyo chainyo merged commit f8d6510 into main Oct 4, 2023
2 checks passed
@chainyo chainyo deleted the 259-implement-only_transcription branch October 4, 2023 07:47
@chainyo chainyo mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov aleksandr-smechov approved these changes

Assignees
No one assigned
Labels
api Everything related to the API implementation diarization Everything related to the diarization part transcription Everything related to the transcription part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement only_transcription
2 participants
@chainyo @aleksandr-smechov