Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps for Dart 3 #432

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Upgrade deps for Dart 3 #432

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a994ba6
Upgrade deps for Dart 3
robbecker-wf Sep 5, 2024
0029fd6
add an exclude for failing depval
robbecker-wf Sep 5, 2024
aa73c90
address depval
robbecker-wf Sep 5, 2024
7df14a8
update depval config to match dart_dev
robbecker-wf Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dart_dependency_validator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
exclude:
- test/tools/fixtures/organize_directives/directives.dart
- test/tools/fixtures/analyze/failing/failing.dart
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an invalid dart file (intentionally for tests) but causes the analyzer to throw when running dependency validator (looking for import statements). Added to the exclude list to avoid dependency validator breaking in CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on updating this to: test/**/fixtures/**.dart to mirror what we have in the dart_dev config? https://github.com/Workiva/dart_dev/blob/master/tool/dart_dev/config.dart#L9

10 changes: 5 additions & 5 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@ description: >
repository: https://github.com/Workiva/dart_dev

environment:
sdk: '>=2.18.0 <4.0.0'
sdk: '>=2.19.0 <4.0.0'

dependencies:
analyzer: '>=2.0.0 <6.0.0'
analyzer: '>=5.0.0 <7.0.0'
args: ^2.0.0
async: ^2.5.0
build_runner: ^2.0.0
crypto: ^3.0.1
glob: ^2.0.0
io: ^1.0.0
Expand All @@ -26,8 +25,9 @@ dependencies:
collection: ^1.15.0

dev_dependencies:
dependency_validator: ^3.0.0
lints: '>=1.0.1 <3.0.0'
build_runner: ^2.0.0
dependency_validator: ^4.0.0
lints: '>=2.0.0 <5.0.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update dependencies to allow Dart 3 versions of packages

matcher: ^0.12.5
test: ^1.15.7
test_descriptor: ^2.0.0
Expand Down
1 change: 1 addition & 0 deletions test/utils/get_dart_version_comment_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@TestOn('vm')
@Tags(['dart2'])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test explodes on Dart 3 because there are @dart=2.9 comments that don't work in Dart 3. The lowest version you can use in a comment like that in Dart 3 is 2.12 (null safety).

import 'package:dart_dev/src/utils/get_dart_version_comment.dart';
import 'package:test/test.dart';

Expand Down