Code

WIP: Null safety#828

Code

Closed

hunterbreathat-wk wants to merge 186 commits intomasterWorkiva/over_react:masterfrom null-safetyWorkiva/over_react:null-safetyCopy head branch name to clipboard

+8,511-9,109

Commits

Commits on Feb 4, 2021

• Widen analyzer dependency range to fix dev channel builds

  aaronlademann-wf

  committed
  3b25e84

• Move git diff check to its own step

  aaronlademann-wf

  committed
  155d73e

• Try adding comments to speed up dev build?

  aaronlademann-wf

  committed
  e8305c4

Commits on Feb 5, 2021

• Remove build_web_compilers/build_modules overrides

  Show description for 800a9fc
  aaronlademann-wf

  committed
  800a9fc

Commits on Mar 17, 2021

• Copy dart version comment in generated parts

  aaronlademann-wf

  committed
  8f3a081

• Let the consumer know we don’t support this ish yet

  aaronlademann-wf

  committed
  fb6d7ce

Commits on May 20, 2021

• Merge branch 'master' of github.com:Workiva/over_react into widen-analyzer-range

  aaronlademann-wf

  committed
  5b31e99

• Merge branch 'widen-analyzer-range' into null-unsafe-compat-builder

  aaronlademann-wf

  committed
  570b422

Commits on May 28, 2021

• Prep for null-safety

  greglittlefield-wf

  committed
  ad10b8b

• Generate files

  greglittlefield-wf

  committed
  15cb823

• Add some hints

  greglittlefield-wf

  committed
  e6aece8

• Clean up some code to be easier to make null-safe

  greglittlefield-wf

  committed
  c317210

• Use null safety tool to migrate most non-builder code in lib, adding hints but not applying the migration

  Show description for ceaebc9
  greglittlefield-wf

  committed
  ceaebc9

• More migration hints in core lib/src/component files

  greglittlefield-wf

  committed
  8057181

• Convert builder to be null-safe (minus using null safe deps like analyzer)

  greglittlefield-wf

  committed
  2b748f4

• Fix hints

  greglittlefield-wf

  committed
  8d905e1

Commits on Jun 15, 2021

• Upgrade to latest analyzer

  greglittlefield-wf

  committed
  09be6c8

Commits on Jun 16, 2021

• Remove BuiltReduxUiComponent and related built_redux APIs

  greglittlefield-wf

  committed
  78afd8b

• Fix unnecessary ReactElement cast lints

  greglittlefield-wf

  committed
  64f2a42

• Don't reference removed forwardRef

  greglittlefield-wf

  committed
  1e7b574

• Fix misc lints

  greglittlefield-wf

  committed
  3f5846d

Commits on Jul 23, 2021

• Remove dart2_constant dependency

  greglittlefield-wf

  committed
  3114e3b

• Point to null safety transformer utils branch

  greglittlefield-wf

  committed
  f830756

• Upgrade all dependencies to null safe releases except for w_common/w_flux/over_react_test

  greglittlefield-wf

  committed
  0ddfc25

• Fix analysis errors after upgrading dependencies

  greglittlefield-wf

  committed
  f2f827a

• Apply migration (Dart 2.13.3)

  greglittlefield-wf

  committed
  1687b64

• Fix analysis errors in builder after running migration

  greglittlefield-wf

  committed
  909a57f

• Fix warnings in builder after running migration

  greglittlefield-wf

  committed
  ad08ea2

• Fix lints in builder after running migration

  greglittlefield-wf

  committed
  2da1db8

• Remove conflicting extensions declared in package:collection

  greglittlefield-wf

  committed
  191cbb5

• Fix errors in builder tests

  greglittlefield-wf

  committed
  a726eea

• Fix lots of unnecessary null-aware warnings

  greglittlefield-wf

  committed
  7c78411

• Fix remaining warnings in builder tests

  greglittlefield-wf

  committed
  7960c07

• Add missing null check

  greglittlefield-wf

  committed
  2d44d59

• Remove build configs for remove dependencies

  greglittlefield-wf

  committed
  b6f1564

• Fix syntax error in component_base.dart

  greglittlefield-wf

  committed
  d5898bd

• Fix DummyComponent2 implementation

  greglittlefield-wf

  committed
  cd91e96

• Update builder to emit correct nullability in generated code

  greglittlefield-wf

  committed
  22871ca

• Update generated code

  greglittlefield-wf

  committed
  0f9bfb8

• Add missing late

  greglittlefield-wf

  committed
  1ef30bd

• Update generated code

  Show description for f325b38
  greglittlefield-wf

  committed
  f325b38

• Fix overrides in component_base

  greglittlefield-wf

  committed
  256f593

• Attempt to fix nullability issues in component_declaration and util

  greglittlefield-wf

  committed
  617df73

• Fix nullability issues in internal components

  greglittlefield-wf

  committed
  54f1c8f

• Generate code

  greglittlefield-wf

  committed
  0374035

• Fix syntax error in test

  greglittlefield-wf

  committed
  1c93705

• Fix Redux nullability issues

  greglittlefield-wf

  committed
  9795e89

• Fix bad casts added by tool

  greglittlefield-wf

  committed
  45491fe

• Tweak nullability on prop key utils

  greglittlefield-wf

  committed
  8356f21

Commits on Jul 24, 2021

• Properly convert CSSValue parsing to null safety

  greglittlefield-wf

  committed
  10ad6c2

• Fix null and null-aware warnings

  greglittlefield-wf

  committed
  b1f2669

• Fix incorrect null safety conversions

  greglittlefield-wf

  committed
  de928f1

• Clean up null checks

  greglittlefield-wf

  committed
  eec4a99

• Fix nullability in Component2

  greglittlefield-wf

  committed
  b24969d

• Null check cleanup

  greglittlefield-wf

  committed
  8785b15

• Fix InfluxStoreMixin nullability

  greglittlefield-wf

  committed
  7ace186

• Use runZonedGuarded instead of deprecated runZoned

  greglittlefield-wf

  committed
  869d2ac

• Add more hasher test cases to support refactoring

  greglittlefield-wf

  committed
  6239714

• Fix a bunch of small nullability errors/warnings/lints

  greglittlefield-wf

  committed
  a84e48a

• Fix incorrect nullability

  greglittlefield-wf

  committed
  607097c

• Remove unused meta imports

  greglittlefield-wf

  committed
  3152bd6

• Fix disposable method migration

  greglittlefield-wf

  committed
  46d2c07

• Make getProps/getDartComponent dynamic so that consumers don't need to do any casting to Object

  greglittlefield-wf

  committed
  2a341aa

• Clean up react wrappers tests

  greglittlefield-wf

  committed
  8240478

• Add missing not-null-assertions

  greglittlefield-wf

  committed
  7273755

Commits on Feb 27, 2023

• Merge remote-tracking branch 'origin/master' into null-safety

  greglittlefield-wf

  committed
  a436845

• Fix builder analysis errors after master merge

  greglittlefield-wf

  committed
  c23a399

• Upgrade changes from master to null safety, misc fixes after merge

  greglittlefield-wf

  committed
  6225af6

• Re-generate over_react parts

  greglittlefield-wf

  committed
  44731dc

• Update mockito mocks

  greglittlefield-wf

  committed
  a6a897f

• More misc null safety error fixes

  greglittlefield-wf

  committed
  8c13e2d

• Fix lints related to type checking

  greglittlefield-wf

  committed
  353f5d4

Commits on Feb 28, 2023

• Remove unnecessary casts

  greglittlefield-wf

  committed
  19a8475

Commits on Mar 2, 2023

• Add null-checks for non-nullable props, add nullability example

  greglittlefield-wf

  committed
  51d5964

Commits on Mar 30, 2023

• Conditionally generate null safe code (not using pubspec constraint yet)

  greglittlefield-wf

  committed
  7fe5a1e

Commits on Jun 11, 2023

• Null-safe props: fix null checks / null awares

  greglittlefield-wf

  committed
  ebec2f2

• Attempt to improve migrator tool inference when encountering generated accessors

  greglittlefield-wf

  committed
  d4851ed

• Factor late-ness into prop requiredness metadata

  greglittlefield-wf

  committed
  9ba7c46

• Use uiJsComponent where possible so that we can benefit from props class codegen

  Show description for 561f66d
  greglittlefield-wf

  committed
  561f66d

• Use defaults when possible in accessor generation

  greglittlefield-wf

  committed
  5ef8f6b

• Re-enable null safety in builder

  greglittlefield-wf

  committed
  541601f

• Re-generate with null-safe parts and updated accessors

  greglittlefield-wf

  committed
  c49db91

• Default to null-safe builder output only for over_react for the time being

  greglittlefield-wf

  committed
  5686fb0

Commits on Jun 12, 2023

• Add proof-of-concept for new required prop validation

  greglittlefield-wf

  committed
  08a52d4

• Missing required prop diagnostic: clean up, add support for late

  greglittlefield-wf

  committed
  9cb3308

• Add support for accessing non-nullable props in getPropKey, handle non-operator[] reads

  greglittlefield-wf

  committed
  5a0a454

Commits on Jun 16, 2023

• Merge branch 'master' into null-safety

  Show description for 812289c
  hunterbreathat-wk

  committed
  812289c

• Update deps

  hunterbreathat-wk

  committed
  c42570a

• Update deps

  hunterbreathat-wk

  committed
  307ffc1

• Update deps

  hunterbreathat-wk

  committed
  11a9074

• Update deps....

  hunterbreathat-wk

  committed
  4135ecb

• Update deps....

  hunterbreathat-wk

  committed
  5b4760f

Commits on Jun 20, 2023

• Tweak workflow, move dependency_validator config

  hunterbreathat-wk

  committed
  09a986f

• Bump min to 2.18.7

  hunterbreathat-wk

  committed
  03be47a

• Tweaking pubspec

  hunterbreathat-wk

  committed
  800e38f

• Resolve dependency issues

  hunterbreathat-wk

  committed
  1441d03

• Resolve dependency issues

  hunterbreathat-wk

  committed
  f3bf23e

• Fix dart_dependency_validator

  hunterbreathat-wk

  committed
  98130a8

• Tweaks to react version and remove null safe check

  hunterbreathat-wk

  committed
  4b7f25b

• (Test) Changes related to core lib

  hunterbreathat-wk

  committed
  010d5a2

• (Test) Misc remaining fixes

  hunterbreathat-wk

  committed
  0d33b34

• (Test) Fix temp override

  hunterbreathat-wk

  committed
  aeb4111

• (Test) Fix analyzer warning

  hunterbreathat-wk

  committed
  551be17

• (Test) Fix analyzer warning...

  hunterbreathat-wk

  committed
  b8df980

Commits on Aug 25, 2023

• Update react-dart null safety branch, adjust errors and ref typings

  greglittlefield-wf

  committed
  efc89c7

• Clean up casts and nullability in getProps

  greglittlefield-wf

  committed
  e1ace93

Commits on Aug 29, 2023

• Disable spike validateRequiredProps implementation

  greglittlefield-wf

  committed
  cff04d5

• Fix casts to non-nullable values, enable lint

  greglittlefield-wf

  committed
  fa13972

• Commit generated code

  greglittlefield-wf

  committed
  6ce859d

• Fix CssValue.parse handling of non-finite num values

  greglittlefield-wf

  committed
  bbe7a77

• Fix bad casts in AbstractTransition tests

  greglittlefield-wf

  committed
  f01a402

• Remove function casts added by migrator tool that are either incorrect or unnecessary

  greglittlefield-wf

  committed
  f4cd005

• Fix errors after removing casts

  greglittlefield-wf

  committed
  9287ee5

• Fix nullability of flux actions in test fixture and examples

  greglittlefield-wf

  committed
  84f954c

• Fix some typing in prop conversion and its tests

  greglittlefield-wf

  committed
  44e2466

• Revert dummy_component2 changes, add note about why it's generated

  greglittlefield-wf

  committed
  809d427

• Check in forgotten dummy_component2 generated file

  greglittlefield-wf

  committed
  fd4d839

• Update getPropKey tests to reflect new implementation

  greglittlefield-wf

  committed
  371c05c

Commits on Aug 30, 2023

• Fix more tests

  greglittlefield-wf

  committed
  a51b2cf

• Sync ref APIs with react-dart, update usages

  greglittlefield-wf

  committed
  2ed7a1a

• Fix cast_nullable_to_non_nullable warnings in tests

  greglittlefield-wf

  committed
  825895e

• Remove unused import

  greglittlefield-wf

  committed
  cf345d4

Commits on Aug 31, 2023

• Fix remaining cast_nullable_to_non_nullable warnings

  greglittlefield-wf

  committed
  a174582

• Fix broken propTypes due to out-of-sync JS wrapper with incorrect argument types

  Show description for 57e0e1f
  greglittlefield-wf

  committed
  57e0e1f

• Fix connect not working with null state, use type alias

  greglittlefield-wf

  committed
  26553dc

• Clean up noisy test output

  greglittlefield-wf

  committed
  4ffbee7

• Clean up noisy test output

  greglittlefield-wf

  committed
  b5ea8e6

Commits on Sep 5, 2023

• Upgrade Dockerfile Dart version

  greglittlefield-wf

  committed
  ab0ade7

• Upgrade Dockerfile Dart version

  greglittlefield-wf

  committed
  3848103

Commits on Sep 13, 2023

• Update Component2Bridge call with new nullability

  greglittlefield-wf

  committed
  b28c80e

• Fix getDebugNameForDartComponent

  greglittlefield-wf

  committed
  2039a4e

Commits on Oct 6, 2023

• Reinstate ?? null in generated accessors until we work around the undefined bug in JsBackedMap

  greglittlefield-wf

  committed
  1d4262a

• Update generated code

  greglittlefield-wf

  committed
  db6e6e7

Commits on Oct 10, 2023

• Merge remote-tracking branch 'origin/master' into null-safety

  Show description for 31ec0ab
  greglittlefield-wf

  committed
  31ec0ab

• Update generated code

  greglittlefield-wf

  committed
  6b755e8

• Remove dart_dev override, re-enable dart_dev

  greglittlefield-wf

  committed
  09bb9e7

• Remove unused built_redux dependency

  greglittlefield-wf

  committed
  c4f62fd

• Clean up nullabilities

  greglittlefield-wf

  committed
  ec4bca4

• Clean up import

  greglittlefield-wf

  committed
  c06c231

• Merge branch 'prepare-for-react-dart-v7' into null-safety

  greglittlefield-wf

  committed
  4254fe4

Commits on Oct 11, 2023

• Clean up nullability in builder code

  greglittlefield-wf

  committed
  e772873

• Fix typing of firstWhereType

  greglittlefield-wf

  committed
  5f3ccf6

• Clean up non-null assertions on codegen fields sourceFile/outputContentsBuffer/logger

  greglittlefield-wf

  committed
  1f699b8

• Clean up nullability

  greglittlefield-wf

  committed
  da70d64

Commits on Oct 12, 2023

• Update MissingRequiredProp after upgrading to analyzer 5

  greglittlefield-wf

  committed
  7ee39a5

• Clean up analyzer_plugin ignores now that the over_react builder is null-safe

  greglittlefield-wf

  committed
  c6ac61a

• Migrate test and tool entry points to null safety

  greglittlefield-wf

  committed
  b01e498

Commits on Oct 13, 2023

• Re-enable diagnostics that imported non-null-safe builder code

  greglittlefield-wf

  committed
  52573f1

• Merge remote-tracking branch 'origin/master' into null-safety

  greglittlefield-wf

  committed
  e688b3f

Commits on Oct 16, 2023

• Update react-dart branch

  greglittlefield-wf

  committed
  a78586e

• Reenable type overrides since tests currently expect them

  greglittlefield-wf

  committed
  c7d94ff

• Conditionally output Accessor arguments to match old generation

  greglittlefield-wf

  committed
  510f294

• Opt existing test cases with gold files out of null safe generation

  greglittlefield-wf

  committed
  5fa0d13

• Fix inverted boolean typo

  greglittlefield-wf

  committed
  ccc0b84

• Fix accidentally removed annotationCount++

  greglittlefield-wf

  committed
  4c0f4e7

• Update generated code after PropDescriptor argument changes

  greglittlefield-wf

  committed
  16bb496

• Update generated code after restoring types in accessor overrides

  greglittlefield-wf

  committed
  903a8b1

Commits on Nov 13, 2023

• Clean up null safety in redux dev tools middleware

  greglittlefield-wf

  committed
  406432e

• Clean up spike implementations, update FIXMEs

  greglittlefield-wf

  committed
  bf4d91d

• Point to released react

  greglittlefield-wf

  committed
  6f20410

• Clean up non-null assertion operators

  greglittlefield-wf

  committed
  e7e0069

• Clean up nullable iterable check

  greglittlefield-wf

  committed
  f98bbfa

• Make dom/aria helpers late final

  greglittlefield-wf

  committed
  c86e202

• Fix generic parameter nullability

  greglittlefield-wf

  committed
  222bbea

• Make cloneElement argument non-nullable

  greglittlefield-wf

  committed
  fdf11a3

• Fix weird casting

  greglittlefield-wf

  committed
  8541686

• Make TActions arguments in connect callbacks not nullable

  greglittlefield-wf

  committed
  cf2148c

• Get on null-safe w_flux, update Action usages

  greglittlefield-wf

  committed
  118b145

• Clean up missing required prop spike

  greglittlefield-wf

  committed
  97e6216

• Remove outdated FIXME

  greglittlefield-wf

  committed
  5952428

• Clean up required props validation spike code

  greglittlefield-wf

  committed
  2780838

• Clean up example / test Action class nullability

  greglittlefield-wf

  committed
  fbc30d4

Commits on Nov 14, 2023

• Clean up LHS types added by migrator

  greglittlefield-wf

  committed
  7132160

• Clean up nullability in examples

  greglittlefield-wf

  committed
  3939b10

• Clean up validateRequiredProps more

  greglittlefield-wf

  committed
  b47f2e3

• Revert accidental changes

  greglittlefield-wf

  committed
  5779ef9

• Remove bad cast

  greglittlefield-wf

  committed
  0e5145b

• Clean up closest impl, make more optimal, null-safe

  greglittlefield-wf

  committed
  199feb4

• Clean up empty lines from language version comments

  greglittlefield-wf

  committed
  9644fb4

• Revert ReactElement return types made nullable by migrator

  greglittlefield-wf

  committed
  f987644

• Remove unnecessary ReactElement typings added by migrator

  greglittlefield-wf

  committed
  8057d39

• Clean up SafeRenderManager tests nullability

  greglittlefield-wf

  committed
  71a2dc5

• Clean up unnecessary LHS function types added by migrator

  greglittlefield-wf

  committed
  f5879d1

• Fix handler chaining nullability

  greglittlefield-wf

  committed
  2ee5ba9

• Add WIP 5.0.0 changelog entry

  greglittlefield-wf

  committed
  fab842c

• Merge remote-tracking branch 'origin/master' into null-safety

  greglittlefield-wf

  committed
  dcf2bca