Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-213359 RM-213358 Release over_react 4.10.2 #840

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Sep 15, 2023

There was a problem publishing 4.10.1 because of a nested test_fixture directory. Adding it to the .pubignore works around this issue.

Bad state: Unable to find the context to /Users/greglittlefield/workspaces/over_react2/tools/analyzer_plugin/test/test_fixtures/over_react_project/lib/analysis_warmup.dart
package:pub/src/dart.dart 119:5                           AnalysisContextManager._getExistingSession
package:pub/src/dart.dart 83:23                           AnalysisContextManager.parse
package:pub/src/dart.dart 102:16                          AnalysisContextManager.parseImportsAndExports
package:pub/src/validator/strict_dependencies.dart 35:45  StrictDependenciesValidator._findPackages
dart:async                                                _SyncStarIterator.moveNext
package:pub/src/validator/strict_dependencies.dart 95:23  StrictDependenciesValidator._validateBenchmarkTestTool
package:pub/src/validator/strict_dependencies.dart 71:5   StrictDependenciesValidator.validate
package:pub/src/validator.dart 166:23                     Validator.runAll.<fn>
dart:async                                                Future.wait
package:pub/src/validator.dart 164:25                     Validator.runAll
===== asynchronous gap ===========================
package:pub/src/command/lish.dart 263:5                   LishCommand._validate
===== asynchronous gap ===========================
package:pub/src/command/lish.dart 236:19                  LishCommand.runProtected
This is an unexpected error. The full log and other details are collected in:

@rmconsole2-wf rmconsole2-wf changed the title Release over_react 4.10.2 RM-213359 RM-213358 Release over_react 4.10.2 Sep 15, 2023
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf
Copy link
Contributor Author

Versions match, Rosie output looks good

QA +1

@greglittlefield-wf
Copy link
Contributor Author

@Workiva/release-management-pp

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit c304153 into master Sep 15, 2023
6 checks passed
@rmconsole3-wf rmconsole3-wf deleted the release_over_react_4_10_2 branch September 15, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants